Fix updating the block list after block removal #35721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Size Change: +25 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
fluiddot
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
LGTM 🎊 !
I verified that the issue is no longer present for the case of removing the first block at the root level, as well as for the case of removing the first block within another block like the group block.
Additionally, I did a quick check on the native version to confirm that couldn't be reproduced in that version either.
geriux
pushed a commit
that referenced
this pull request
Oct 20, 2021
5 tasks
1 task
geriux
pushed a commit
that referenced
this pull request
Oct 21, 2021
* Release script: Update react-native-editor version to 1.64.0 * Release script: Update with changes from 'npm run core preios' * Update Changelog * Release script: Update react-native-editor version to 1.64.1 * Release script: Update with changes from 'npm run core preios' * Fix updating the block list after block removal (#35721) * Cover block: Change dimRatio to 50 if media added and dimRatio is set to 100 (#35789) * Change opacity to 50 if media added and opacity is set to 100 to prevent background color obscuring image * Fixes cover opacity bug on mobile (#35792) Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> * Mobile - Update Changelog Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35624
The refactoring in #34241 introduce a small bug that happens when the "REPLACE_BLOCKS" action is triggered with an empty block list causing the removal of the replaced block. In this situation, the block list was not being updated properly in the state.
Testing instructions