[Block Library - Query Loop]: Add support for custom taxonomies filtering #38063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
aristath,
gziolo,
jameskoster,
kjellr,
jasmussen,
michalczaplinski,
fabiankaegy and
cbravobernal
ntsekouras
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +244 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
fabiankaegy
reviewed
Jan 19, 2022
packages/block-library/src/query/edit/inspector-controls/index.js
Outdated
Show resolved
Hide resolved
|
I have now also tested this locally and it is working like a charm :) Exactly what you would expect. In a follow up I think we can improve the UX by using the pattern established by the spacing & font controls where not all controls are shown by default but rather you can use the ellipsis to hide/show individual items because it can easily get very cluttered when you have many taxonomies. I believe that @shaunandrews has done a design exploration for this but I am unable to find it at the moment :( |
aristath
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
This looks good, awesome work @ntsekouras!
Works as expected and also cleans up some code, making things easier to understand and follow.
I only had a minor comment regarding spacing, but I'll go ahead and pre-approve it 👍
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
@fabiankaegy that's exactly what I had in mind for the next steps for the block 😄. I think it's time to start the new overview issue we talked about, to get suggestions and prioritize things. |
|
Thanks so much for working on this @ntsekouras! So appreciated! |
20 tasks
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #34977
This PR adds support for custom taxonomies filtering. In order to do that I had also had to change the way the block was holding information about tags and categories with explicitly defined props(
categoryIds, tagIds).I added a new property in the
queryattribute which is calledtaxQueryand holds the relevant information. My original plan was to split this PR in two (migrate totaxQueryand add custom taxonomies support), but the only difference would be to whitelist the previous supported taxonomies(categories, tags) so it didn't make much sense..Show case
Existing Query Loop blocks
In the below video I initially show an existing
Query Loopblock (both editor and front end) withcategories and tagsfilters - I also highlight the set properties in code editor. After that I reload the pages with the new code to show the proper migration of the existing values by using thetaxQueryproperty.existing.blocks.mov
Custom taxonomies
In the following video I add some WooCommerce product categories filter:
custom.taxonomies.mov
Testing instructions
Query Loopshould work as before with no regressionsQuery Loopblocks with the new taxonomy filters (try any combination)post typefilter that should show conditionally the available taxonomies' filters and reset the unavailable ones