[Block Library - Query Loop]: Fix some missing term sanitizations #39970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
cbravobernal
approved these changes
Apr 1, 2022
ntsekouras
force-pushed
the
fix/query-use-sanitized-termids
branch
from
31093ce to
4da26a2
Compare
9 tasks
ntsekouras
commented
Apr 1, 2022
| $term_ids = array_map( 'intval', $terms ); | ||
| $term_ids = array_filter( $term_ids ); | ||
|
|
||
| if ( is_taxonomy_viewable( $taxonomy ) && ! empty( $terms ) ) { |
There was a problem hiding this comment.
is_taxonomy_viewable checks if the taxonomy is publicly_queryable. --cc @peterwilsoncc
ntsekouras
changed the title
ntsekouras
force-pushed
the
fix/query-use-sanitized-termids
branch
from
2ae0f0e to
b200750
Compare
hellofromtonya
added a commit
to hellofromtonya/wordpress-develop
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug found by @hellofromtonya here.
It should use the sanitized value(
$term_ids).Notes
The changes of this PR when merged, need to be added to the core PR here: WordPress/wordpress-develop#2488.
Testing instructions