Add default as
prop to PluginMoreMenuItem
component
#39517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #39474
What?
This PR resolves the issue reported in #37474 by providing a default
as
prop of theMenuItem
component. This solution allows users to continue to override theas
prop just as behavior was previously.Why?
By being able to use the MenuItem we gain the benefits of existing work done to handle aria attributes for example among other benefits such as styling consistency.
How?
Minimal JavaScript changes to this package. Should only affect custom menu elements in the editor.
Testing Instructions
With this PR the following snippet will render a
MenuItem
as explained in thePluginMoreMenuItem
docsScreenshots or screencast