[RNMobile] Fix broken "Link To" settings and add "Image Size" settings #40947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2022 20:27
Requests using "per_page=-1" (unbounded queries) are not supported on mobile, as per: wordpress-mobile/gutenberg-mobile#2661 As an unbounded query was being used to fetch inner images in the gallery, the "link to" settings were not working as expected on native. With this commit, the unbounded query is replaced with "imageIds.length" to fix the issue on native.
SiobhyB
added
[Block] Gallery
|
Size Change: -117 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
SiobhyB
changed the title
|
@Mamaduka, thanks so much for taking a look! I hadn't been aware that unbounded queries were unsupported on native until diving into this bug either.
Appreciate the heads-up, I've gone ahead to resolve the conflict now. 🙇♀️ Let me know if anything looks off or if you spot any regressions on the web-side that I may have missed. Aside: Looking at the changes in #40945, I'm wondering if the introduction of |
|
It might be a good idea to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23576
Related PRs
gutenberg-mobile: [RNMobile] Fix broken "Link To" settings and add "Image Size" settings wordpress-mobile/gutenberg-mobile#4841What?
This PR fixes the native version of the Gallery block's broken Link To settings and also adds Image Size settings.
Why?
The reason that the settings are broken in the native version of the block is that
per_page=-1(an unbounded query) is used when fetching the gallery's images. Unbounded queries aren't currently supported on the native side, as per the open issue at wordpress-mobile/gutenberg-mobile#2661.Updating the query, not only fixes the broken Link To settings, but also enables support for the Image Size settings, which become visible in the native block's settings.
How?
With this PR, the unbounded query is replaced with
imageIds.lengthto fix the issue on native. This approach was chosen as it was initially suggested here: #34389 (comment)Testing Instructions
1. Link To Settings
<a href="URL">tags are surrounding the gallery's images.2. Image Size Settings
size-largeif Large was selected) has been added to the HTML for the gallery's images.3. Regression Testing
We should confirm that the Gallery block still works the same as it did before on the web, by experimenting with the its settings with this branch checked out on the web.
Screenshots or screencast
You'll see that the
<a href="URL">tags are correctly added when using the Link To settings within the app:Screen.Recording.2022-05-09.at.20.38.14.mov