Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Fix broken "Link To" settings and add "Image Size" settings #40947

Merged
merged 5 commits into from
May 10, 2022
Merged

[RNMobile] Fix broken "Link To" settings and add "Image Size" settings #40947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56b6c9d
Replace unbounded query to fix gallery settings
May 9, 2022
280cf6a
Update CHANGELOG
May 9, 2022
2cd0e61
Update CHANGELOG
May 9, 2022
a4ee48e
Merge branch 'trunk' into rnmobile/fix/gallery-link-to-settings
May 10, 2022
b89791b
Update unbounded query (unsupported on native)
May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/use-get-media.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default function useGetMedia( innerBlockImages ) {

return select( coreStore ).getMediaItems( {
include: imageIds.join( ',' ),
per_page: -1,
per_page: imageIds.length,
orderby: 'include',
} );
},
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/use-short-code-transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function useShortCodeTransform( shortCodeTransforms ) {

return select( coreStore ).getMediaItems( {
include: imageIds.join( ',' ),
per_page: -1,
per_page: imageIds.length,
orderby: 'include',
} );
},
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ For each user feature we should also add a importance categorization label to i

- [**] [Buttons block] Fix Android-only issue related to displaying formatting buttons after closing the block settings [#40725]
- [**] [Cover block] Improve color contrast between background and text [#40691]
- [*] [Gallery block] Fix broken "Link To" settings and add "Image Size" settings [#40947]

## 1.75.0

Expand Down