Makepot: Fix translations object handling #43797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
|
@WordPress/gutenberg-core - is this something that is worth an early point release? Or should we wait for the regular release cycle? |
|
Let's wait for the next regular Gutenberg RC release. It was moved to Tuesday next week, but it isn't that far away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes #43793.
Why?
In #43479 we broke how we handle translations, incorrectly asserting that they were an array, while they are an object.
How?
This PR fixes that by converting the object to an array before sorting it.
This will need a point release.
Testing Instructions
npm run build.node_modules/@wordpress/babel-plugin-makepot/index.jsto:
npm run build