Lodash: Refactor away from _.merge()
#48239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
jeremyfelt,
sgomes,
aristath,
jsnajdr,
gziolo,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +290 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 291f545. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4232748699
|
tyxla
force-pushed
the
remove/lodash-merge
branch
from
017f2fc to
4d6be7b
Compare
jsnajdr
approved these changes
Feb 21, 2023
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Internal | |||
|
|
|||
| - Lodash: Refactor away from `_.merge()` ([#48239](https://github.com/WordPress/gutenberg/pull/48239)). | |||
There was a problem hiding this comment.
In a changelog message I would say that the lodash dependency has been removed from the package. It's something that's visible and useful for the package consumer, unlike the purely internal merge refactor.
There was a problem hiding this comment.
Good call. Expanded the CHANGELOG message in 291f545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.merge()from thebabel-plugin-makepotpackage. It's the last usage, so we're also deprecating that method. Finally, we're removing a stray_.isEmpty()which is straightforward enough to remove.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
deepmergeinstead of_.merge(), which has been properly used as a substitute in other places of the codebase where we need deep merging of objects. We're using an additional bool check andObject.values().lengthto replace theisEmpty()over an object.Testing Instructions
babel-plugin-makepotin its build pipeline. If you don't have one, you could start with the one mentioned at babel-plugin-makepot: "translations is not iterable" #43793node_modules, similar to how we did in Makepot: Fix translations object handling #43797.cc @jeremyfelt who has historically been capable to test changes on this package - I'd really appreciate a review on this one. 🙌