Update the Gutenberg plugin to require at least the WP 6.0 version #46102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
Gutenberg Plugin
|
|
youknowriad
changed the title
|
Size Change: +26 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Yes, that should be correct from the web perspective, will let @geriux confirm from mobile side. With the removal of the v1 code the edit-wrapper was redundant, so have removed that. |
We checked the adoption metrics of V2 vs V1 in native and seems like we still have a meaningful ratio of users using V1, mainly in self-hosted sites. This means that if we remove Gallery block V1, those users won't be able to edit the Gallery block in the app. On the other hand, I'm concerned that it will take a long time until we get a high adoption of Gallery V2, and I understand that we'd like to remove V1, especially now that we have three WP versions out that support V2 (i.e. 5.9, 6.0 and 6.1). One option we're discussing is to render the Gallery block unsupported in the native version if it's V1. However, for this, we'd need to work on that implementation before removing the Gallery block V1 code. @youknowriad would it be possible to delay merging this PR until we provide a workaround for the native version? Thanks! cc @geriux |
|
Hey there 👋 we are ok with removing the V1 of the Gallery block 👍 but we are currently looking into a workaround for users that haven't updated yet which is still a bit high for us to remove all of it without informing the users or breaking the user experience. |
|
@geriux Since in the web, the Gutenberg plugin now only works with Gallery V2, can we keep the v1 code for the mobile and ship the current PR with the web changes. In other words, would it be possible to revert all my "native" file changes here and ship? |
Would that revert include the changes in the Gallery files that are not "native" but are shared with mobile? |
It seems like these include the whole gallery block changes (almost), this makes the revert less tempting to me. I guess it's better to wait here until you all come up with the right workaround in that case. |
Sounds good, we will need to keep all of the As for the |
|
@geriux would you be able to make the changes in this PR when you figure out how to handle this? |
Sure! Will do 👍 |
youknowriad
force-pushed
the
remove/6.0-support
branch
from
638b707 to
4ac7713
Compare
youknowriad
force-pushed
the
remove/6.0-support
branch
from
4ac7713 to
aafe2b6
Compare
|
Ok, so to avoid blocking this PR further, I've decided to remove all the gallery block related changes. It should be now ready to go. |
Sounds good! Could I make a quick change to have this flag in the mobile block editor settings endpoint? |
|
@geriux Isn't that already set in the WP provided endpoint? |
I'm not sure, which endpoint is that? |
|
@geriux I mean that this is already set on WordPress core directly https://github.com/WordPress/wordpress-develop/blob/0cb8475c0d07d23893b1d73d755eda5f12024585/src/wp-includes/block-editor.php#L233 |
Oh! I see! Sorry I missed that, all good then! Thank you! |
ellatrix
approved these changes
Dec 8, 2022
This was referenced Dec 28, 2022
7 tasks
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WordPress 6.1 is out for a few weeks now, so it's time to update the minimum required WP version to 6.0 for the Gutenberg plugin.
How?
The process I used is to remove the lin/wordpress-6.0 folder and fix any errors. I've noticed that the Gallery block v2 should now always be considered enabled. (Please correct me if I'm wrong @glendaviesnz @ramonjd @geriux) So I went ahead and remove all code related to this check (including on native).
There are some APIs that are marked for removal in WP 6.2 so we can remove them now from the Gutenberg plugin, but I left these for a separate PR.
Testing Instructions
1- Run Gutenberg on top of 6.1
2- Run Gutenberg on top of trunk