Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wp_cache_get in gutenberg_get_global_styles_svg_filters. #47460

Closed
wants to merge 1 commit into from

Conversation

spacedmonkey
Copy link
Member

What?

Part of #45171

wp_get_global_styles_svg_filters: migrate transient to object cache.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions
Copy link

Flaky tests detected in 523925b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4015726150
📝 Reported issues:

@Mamaduka
Copy link
Member

@spacedmonkey, the improved method isn't used anywhere in the plugin. It might make more sense to apply changes directly in the core. What do you think?

@spacedmonkey
Copy link
Member Author

I agree @Mamaduka . See https://github.com/oandregal/wordpress-develop/pull/1 and comment from @oandregal https://github.com/oandregal/wordpress-develop/pull/1#issuecomment-1397804223

@oandregal
Copy link
Member

Right, this method needs to be used in Gutenberg, otherwise, how do we test it? :) Take a look at how wp_get_global_styles_svg_filters for inspiration. I also see that it was removed #46102 so that should be helpful in setting it up.

This also needs testing steps. cc @ajlende for thoughts on what'd be the best to test, as I seem to remember that browsers were a bit funky on this one.

@oandregal oandregal requested a review from ajlende January 26, 2023 15:44
@spacedmonkey
Copy link
Member Author

@oandregal I am going to close this out and move this conversion to core. This is not the best place to test this.

@spacedmonkey
Copy link
Member Author

PR here WordPress/wordpress-develop#3926

@oandregal oandregal deleted the fix/svg-cache branch April 3, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants