Allow developing Gutenberg with NPM v7 and v8 #46400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
Note that I believe there's a temporary workaround for #46443 (comment). We can try that in this PR and see if it works? |
|
@kevin940726 @fluiddot feel free to modify this PR meanwhile, I can help depending on how I find time from other work. |
|
An update for anyone watching this ticket: Today, @carolinan, @SergeyBiryukov. @afercia and I, had a coding session where we tried to upgrade to the latest LTS versions for node/npm. |
|
This is actively worked on at #48950 by @kevin940726, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of Upgrade node and npm to latest LTS versions.
Remove old restriction to use only NPM 6, thus allowing use of NPM 7 and 8.
NPM 6 came with Node.js 14 which is a bit older at this point already: https://github.com/nodejs/release#release-schedule
I'd expect to be able to use at least Node.js 16 or 18 for developing Gutenberg, and thoes come with newer NPM.
It's of course possible to keep using older NPM with newer Node.js, but that's not very convenient.
Why?
Restriction was added 2 years ago because of a bug in NPM. Issue with NPM seems to persist, but:
I don't know if the problem affects Gutenberg anymore; not quite sure how to test either! There's only one
git+httpsdependency but it's for react native editor and I don't know how to test that.Issue commenter noticed the bug doesn't affect NPM 6 when using older Lockfile v1 versions (which Gutenberg currently uses). This could be the case with newer NPM versions, too?
Issue commented offered a solution that seemed to help:
How?
So far I've only removed the restriction and didn't apply the suggested
git+https://gitsolution.Testing Instructions
npm ciTesting Instructions for Keyboard
Screenshots or screencast