-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable lazy loading term meta get_block_templates. #47999
Conversation
Flaky tests detected in fe91ac2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4159058777
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good tweak,again! 🙇🏻
I wonder if some of these (incl. #47998 for example) could use a small comment about why next to them. This way in the future when the optimisations may not be needed or would have to be removed (say some terms are used for whatever reasons) we don't forget about the reasons for these tweaks ...
Similarly with this PR, this is a code quality tweak for a performance enhancement. It's too late for it to go into 6.2. Also by looking at the code now, if this isn't in core right now, it should be under |
Backport ticket - https://core.trac.wordpress.org/ticket/58230 |
Backported. https://core.trac.wordpress.org/changeset/55817 |
What?
Disable lazy loading term meta for
get_block_templates
.Before
After
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast