Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable lazy loading term meta get_block_templates. #47999

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

spacedmonkey
Copy link
Member

What?

Disable lazy loading term meta for get_block_templates.

Before

Screenshot 2023-02-13 at 00 43 20

After

Screenshot 2023-02-13 at 00 43 26

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions
Copy link

Flaky tests detected in fe91ac2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4159058777
📝 Reported issues:

@spacedmonkey spacedmonkey added the [Type] Performance Related to performance efforts label Feb 13, 2023
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tweak,again! 🙇🏻

I wonder if some of these (incl. #47998 for example) could use a small comment about why next to them. This way in the future when the optimisations may not be needed or would have to be removed (say some terms are used for whatever reasons) we don't forget about the reasons for these tweaks ...

@spacedmonkey spacedmonkey merged commit 2c8e618 into trunk Feb 14, 2023
@spacedmonkey spacedmonkey deleted the fix/get_block_templates-prime-term-meta branch February 14, 2023 11:48
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Feature] Template Editing Mode Related to the template editor available in the Block Editor label Feb 14, 2023
@spacedmonkey spacedmonkey added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 27, 2023
@ntsekouras
Copy link
Contributor

Similarly with this PR, this is a code quality tweak for a performance enhancement. It's too late for it to go into 6.2.

Also by looking at the code now, if this isn't in core right now, it should be under compat/6.2 folder, and now should be moved under compat/6.3 folder. @spacedmonkey can you open a PR to move the files in the proper compat folder?

@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 28, 2023
@Mamaduka Mamaduka added the Needs PHP backport Needs PHP backport to Core label Apr 28, 2023
@spacedmonkey
Copy link
Member Author

Backport ticket - https://core.trac.wordpress.org/ticket/58230

@spacedmonkey
Copy link
Member Author

@spacedmonkey spacedmonkey removed the Needs PHP backport Needs PHP backport to Core label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants