Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable lazy loading term meta get_block_templates. #4411

Closed
wants to merge 2 commits into from

Conversation

spacedmonkey
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/58230#ticket


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@oandregal
Copy link
Member

Added Andrei as reviewer. If the original reviewers can be tagged in wordpress-develop, I suggest adding them here, as they know best about the changes. It also helps the review load to be distributed among everyone.

Code-wise the changes are the same from the original PR. There are no test instructions in any place I've checked (here, trac ticket, or the original PR), so I don't know what I should test or what I need to look at. I'll leave space for others to comment here (happy to help if test instructions are provided).

@spacedmonkey
Copy link
Member Author

spacedmonkey commented May 16, 2023

@oandregal As this is a performance improvement, there is no functional change. So that is not to test other than if the code make sense. Do feel free to run benchmarks against this change.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Original PR, merged as part of Gutenberg 15.2: WordPress/gutenberg#47999

@spacedmonkey
Copy link
Member Author

e4e3bb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants