Post editor: Allow root padding setting to affect padding of post title #49460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Size Change: +78 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1f67ea0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4560442728
|
tellthemachines
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Thanks for fixing this! Looks like it was a regression caused by #48663.
andrewserong
deleted the
fix/post-title-padding-when-root-padding-aware-alignments-are-in-use
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While testing #47858, I noticed that the post title in the post editor doesn't currently receive padding rules for themes using
useRootPaddingAwareAlignments(e.g. TwentyTwentyThree).The issue is noticeable in a narrower viewport, for example, when the list view is open. You'll only really notice it when the editor canvas is narrower than the site's content size.
Why?
This is because when
useRootPaddingAwareAlignmentsis in use, we expect thehas-global-paddingclass to be applied to containers where the padding is in use, in order for the padding to be applied as expected (and not to full-width root blocks). For the post title wrapper, this means we need to explicitly output that classname, otherwise it displays as if it were full-width to the edge of the screen (once the viewport is narrower than the content size).How?
has-global-paddingclass whenuseRootPaddingAwareAlignmentsis in use.Testing Instructions
trunk, running TT3, verify the before image below — in narrower viewports with the list view open, the post title wrapper touches the edge of the editor canvas.theme.jsonfile and switchsettings.useRootPaddingAwareAlignmentstofalse, then reload the page. The padding should still be correct, as the padding will now be set further up on the body element viaeditor-styles-wrapper.Screenshots or screencast