Improvements to how blocks with a 'disabled' editing mode behave #51148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent DefaultAppender from appearing in a disabled block. - Disable selection (using user-select: none) in disabled blocks. - Prevent blocks from being inserted into a disabled block via global inserter. - Prevent disabled blocks from being removed via keyboard shortcut. - Prevent disabled blocks from being moved via List View drag and drop. - Prevent block overlay from appearing on a disabled block.
noisysocks
added
[Type] Bug
14 tasks
|
Size Change: -5 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Works as advertised. With the diff applied:
✅ Prevent DefaultAppender from appearing in a disabled block.
✅ Disable selection (using user-select: none) in disabled blocks.
✅ Prevent blocks from being inserted into a disabled block via global inserter.
✅ Prevent disabled blocks from being removed via keyboard shortcut.
✅ Prevent disabled blocks from being moved via List View drag and drop.
✅ Prevent block overlay from appearing on a disabled block.
Tested without patch and can't detect any regressions in editing or template locking
artemiomorales
pushed a commit
to artemiomorales/gutenberg
that referenced
this pull request
Jun 2, 2023
…dPress#51148) - Prevent DefaultAppender from appearing in a disabled block. - Disable selection (using user-select: none) in disabled blocks. - Prevent blocks from being inserted into a disabled block via global inserter. - Prevent disabled blocks from being removed via keyboard shortcut. - Prevent disabled blocks from being moved via List View drag and drop. - Prevent block overlay from appearing on a disabled block.
|
Hello folks, this PR made the "type" performance 30% worse, I think we should definitely look into that. |
|
Will look into it! |
|
Quick update on fixing the performance regression here. I've merged a few PRs that should reduce the number of times that various components re-render while typing: #51628 The main problem introduced by this PR though is that we're now calling
Will open a PR to address these two issues. |
|
Thanks for the follow-ups @noisysocks I appreciate it. It's a bit unfortunate that we had this unexpected change in the metrics recently so we can't see the impact of these improvements on the graph so smoothly. |
|
I've fixed codevitals.run (I had to remove some wrong intermediate numbers). It seems the numbers are not back to where they were before for the typing metric. Do you think #51675 will do the trick? |
|
I think #51675 will definitely be the most impactful change millisecond wise. Let's merge it and see what happens 😅 |
|
I think that's fixed it @youknowriad. The spike at the end seems to be from codevitals getting confused and thinking that 7f4d64b6 comes after a8ce505d. |
|
@noisysocks Thanks indeed. For the order, I do have a "date" saved to be able to order properly but I just discovered that we're always saving the same wrong date. Something to be fixes there 👍 |
noisysocks
added
the
[Feature] Page Content Focus
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…dPress#51148) - Prevent DefaultAppender from appearing in a disabled block. - Disable selection (using user-select: none) in disabled blocks. - Prevent blocks from being inserted into a disabled block via global inserter. - Prevent disabled blocks from being removed via keyboard shortcut. - Prevent disabled blocks from being moved via List View drag and drop. - Prevent block overlay from appearing on a disabled block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follows #50643.
Split out of #50857.
Various improvements to how blocks that have
useBlockEditingMode( 'disabled' )behave.DefaultAppenderfrom appearing in a disabled block.user-select: none) in disabled blocks.Why?
See #50857.
How?
Mostly the changes are at the model level (
canInsertBlockType,canMoveBlock,canRemoveBlock, etc.). Most of the block editor uses these methods to determine which bits of UI to display.Testing Instructions
pbpaste | git apply.