Improve DocumentActions performance #51432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Performance
|
Size Change: +46 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
This is testing nicely for me:
✅ While editing a page, writing text in a paragraph block does not cause the document actions to rerender
✅ Updating the title does, so it's still reactive to page title updates
2023-06-13.12.53.41.mp4
I noticed that while editing part of a template, that the document actions appear to still re-render while typing. Would that be worth following up on separately?
2023-06-13.12.56.48.mp4
Since that appears unaffected by this PR, this LGTM as an iterative performance improvement! ✨
|
Just focusing on what I touched in #50857 right now. I didn't realise this happens when editing a template either... I wonder if it's just never a good idea for us to use |
This was referenced Jun 19, 2023
noisysocks
added
the
[Feature] Page Content Focus
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follows #50857.
Similar to #51319, this updates
DocumentActionsto select the minimal amount of data required. This reduces the number of component remounts and therefore improve typing performance.Why?
How?
Before we used
useEntityRecordwhich is convenient but selects the entire record—much more data than we actually need, and it changes whenever the page content is modified. Using the lower level selectors is better for our use case.Testing Instructions
Screenshots or screencast
Before:
Kapture.2023-06-13.at.12.20.42.mp4
After:
Kapture.2023-06-13.at.12.19.43.mp4