Patterns: Remove reusable text from menu once rename hint has been dismissed
#52664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
Backport to WP 6.7 Beta/RC
ramonjd
reviewed
Jul 16, 2023
|
Size Change: +225 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Working as expected! If @SaxonF / @jameskoster are happy with the workflow then ✅ I'm not sure however if we'd want |
|
@ramonjd have switched to a private API if you have a moment to double check it again please. |
ramonjd
reviewed
Jul 17, 2023
ramonjd
reviewed
Jul 17, 2023
|
Works well for me. Thanks for the updates @glendaviesnz ! 2023-07-17.11.59.38.mp4 |
|
Flaky tests detected in 608836d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5571587277
|
|
I'll defer to @SaxonF who has worked a bit closer to patterns, but the principle seems sound to me. Side note, it's a bit of a shame how the modal width changes when you dismiss the notice. Worth tweaking that here, or something to look into separately? |
Agreed; I'd say separate. |
|
If we do this, it should be removed and replaced with just "Create pattern" prior to 6.4. |
|
It's a bit complicated as an interim solution. We're changing the create reusable block control to create a synced pattern instead, but adding a nudge to indicate that this is where you create reusable blocks. But then the UI changes again, to "Create pattern" which is not the same as creating a synced pattern. I think folks will be in the same scenario regardless of the label switching realistically. I lead towards keeping the toggle setts synced and naming the control "Create synced pattern". This way it performs exactly how the control did in previous versions and is indicative of the action (includes the word "synced"). Then when folks click on it, they see that it is in fact the new language for reusable blocks. |
The new control is the place where users can create both synced and unsynced patterns, not just synced, so |
SaxonF
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
But then the UI changes again, to "Create pattern" which is not the same as creating a synced pattern
Like @glendaviesnz mentioned, you create both synced or unsynced versions of patterns, but they are all just "patterns".
I agree with Rich that its not great the UI changes but it feels like this is an ok compromise based on the feedback provided so far. Let's just make sure to remove it for 6.4.
|
I just cherry-picked this PR to the update/second-round-RC1 branch to get it included in the next release: d186ada |
ramonjd
removed
the
Backport to WP 6.7 Beta/RC
westonruter
added a commit
that referenced
this pull request
Jul 18, 2023
* trunk: (36 commits) Use `_get_block_template_file` function and set $area variable. (#52708) Change Delete page menu item to Move to trash. (#52641) Search block: Enqueue view script through block.json (#52552) Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671) Github workflow: add a PHP backport changes action (#52096) Add layout API documentation. (#52673) Show uncategorized patterns on the Editor > Patterns page (#52633) Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664) Update locked pattern tooltips (#52497) Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682) Use posts instead of template parts for navigation color tests (#52654) Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656) Site Editor: Fix incorrect 'useSelect' usage (#52683) Update issue gardening automation with new label (#52173) i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669) Post Content link color should not be applied to placeholder component links (#52367) [Mobile] Update toolbar icons and colors (#52336) Avoid copying global style presets via the styles compatibility hook (#52640) Show warning on removal of Post Template block in the site editor. (#52666) Backport tools: sort PRs to be cherry picked by merged/closed date (#52667) ...
ramonjd
added a commit
that referenced
this pull request
Jul 18, 2023
* Try restoring the site editor animation (#51956) * Try restoring the site editor animation * fix header animation * Remove accidental addition of layout prop * tidy up formatting * fix animate presence issue * Fix animation between sidebar view and distraction free edit view * Leave sidebar present and maintain canvas to sidebar animation The sidebar is necessary for routing on mobile so we have to maintain its presence in the DOM. Just hiding it isn't enough though, as it is still able to be reached with keyboard tabs and screen readers. Using the relatively new `inert` property disables the element from user interaction, so we add that when we don't want the sidebar to be shown. * Fix mobile view for pattern library On Mobile, the canvas mode wasn't being set to edit when using the pattern library. This updates it to use the showSidbar value instead, keeping it in sync with the inert setting. --------- Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com> * Change password input to type text so contents are visible. (#52622) * Iframe: Silence style compat warnings when in a BlockPreview (#52627) * Do not autofocus page title field in the Create new page modal dialog. (#52603) * Use lowercase p in "Manage Patterns" (#52617) * Remove theme patterns title (#52570) * Block editor store: also attach private APIs to old store descriptor (#52088) As a workaround, until #39632 is merged, make sure that private actions and selectors can be unlocked from the original store descriptor (the one created by `createReduxStore`) and not just the one registered in the default registry (created by `registerStore`). Without this workaround, specific setups will unexpectedly fail, such as the action tests in the `reusable-blocks` package, due to the way that those tests create their own registries in which they register stores like `block-editor`. Context: #51145 (comment) Props jsnajdr * Block removal prompt: let consumers pass their own rules (#51841) * Block removal prompt: let consumers pass their own rules Following up on #51145, this untangles `edit-site` from `block-editor` by removing the hard-coded set of rules `blockTypePromptMessages` from the generic `BlockRemovalWarningModal` component. Rules are now to be passed to that component by whichever block editor is using it. Names and comments have been updated accordingly and improved. * Site editor: Add e2e test for block removal prompt * Fix Shift+Tab to Block Toolbar (#52613) * Fix Shift+Tab to Block Toolbar * Add changelog entry * Show warning on removal of Post Template block in the site editor. (#52666) * Avoid copying global style presets via the styles compatibility hook (#52640) * i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669) * Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682) * Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save * Address feedback * Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664) * Show uncategorized patterns on the Editor > Patterns page (#52633) * Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671) * Pass the root client id into the reusable blocks menu * Check that clientIds array is defined * Make check for array item more specific * Search block: Enqueue view script through block.json (#52552) * Search block: Enqueue view script through block.json * Remove extra space * Use `_get_block_template_file` function and set $area variable. (#52708) * Use `_get_block_template_file` function and set $area variable. * Update packages/block-library/src/template-part/index.php Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> --------- Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> * Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656) * Don't allow template part to be created on the Patterns page for non-block themes * Remove unnecessary theme directory name in E2E test * Change Delete page menu item to Move to trash. (#52641) * Use relative path internally to include packages in dependencies (#52712) * Spacing Sizes: Fix zero size (#52711) * DimensionsPanel: Fix unexpected value decoding/encoding (#52661) --------- Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Andrea Fercia <a.fercia@gmail.com> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com> Co-authored-by: Haz <hazdiego@gmail.com> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: Petter Walbø Johnsgård <petter@dekode.no> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the
/reusable blocktext from theCreate patternmenu once the rename hint has been dismissed. Also sets the default sync status toSyncedto better follow the existing reusable block workflow.Why?
Prevents the additional text hanging around for a full release cycle as the text is not used anywhere else in the interface it is only intended to be a temporary discovery mechanism. See #52194
How?
Checks to see if the reusable block rename hint preference has been toggled off before displaying
Create patternmenu.Testing Instructions
window.wp.data.dispatch(window.wp.preferences.store).set('core', 'isResuableBlocksrRenameHintVisible', true);Create pattern/reusable blockCreate patternwindow.wp.data.dispatch(window.wp.preferences.store).set('core', 'isResuableBlocksrRenameHintVisible', true);and then go to/wp-admin/edit.php?post_type=wp_blockand add a new pattern and make sure the rename hint displays correctly in the modelScreenshots or screencast
patterns-menu.mp4