-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality: Remove "reusable block name hint" code #63514
Conversation
Size Change: -742 B (-0.04%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
### ReusableBlocksRenameHint | ||
|
||
Undocumented declaration. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this a public component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just realized that this component is both private and public at the same time 😅
According to WPdirectory's results, there are two plugins other than the Gutenberg plugin that use this component.
Should we keep this component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if those two plugins are bundling the block-editor
package. I can't find the ReusableBlocksRenameHint
instance in their codebase.
The same is probably true for the "Kubio AI Page Builder" plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded the two plugins. Neither plugin has pre-build code, but looking at the build files, it doesn't look like they use this component.
Therefore, I think it's safe to delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it should be okay. Let's wait until tomorrow if others have different opinions regarding the public component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
Let's merge this. |
Flaky tests detected in 5b7faae. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9990073768
|
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Related to #52664
What?
This PR removes the block name hint, and associated code, from the Create Pattern modal.
Why?
This hint was added in WordPress 6.3 to let users know that the name changed from "Reusable Block" to "Synced Pattern". As this comment indicates, this hint was scheduled to be removed in 6.4, so I don't think it's necessary anymore.
How?
I've removed the relevant components, hooks and CSS. they're private APIs so it should be fine to remove them directly.
Testing Instructions
http://localhost:8888/wp-admin/post-new.php?post_type=wp_block
.