Patterns: Align height of save button and patterns pagination #52764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Jul 19, 2023
| @@ -83,6 +84,7 @@ export default function SaveButton( { | |||
| */ | |||
| showTooltip={ showTooltip } | |||
| icon={ icon } | |||
| __next40pxDefaultSize={ __next40pxDefaultSize } | |||
There was a problem hiding this comment.
The SaveButton component of the edit-site package is also used in the header area of the editor. This button cannot be changed to 40px at the moment, so I have passed __next40pxDefaultSize as props.
|
Size Change: +23 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
t-hamano
added
Needs Design Feedback
jameskoster
approved these changes
Jul 19, 2023
|
@jameskoster Thanks for the quick review 🎉 |
92 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #52663
What?
This PR changes the height of the save button from 32px to 40px on the Patterns page of the Site Editor. At the same time, align the height of the save button area and the pagination area.
Why?
Although not all buttons currently follow that rule, I think the height of the button should be 32px or 40px.
How?
The first question is whether to align the height of the save button with 32px or 40px, but I chose 40px because I believe this button is an important button used throughout the Site Editor. Also in #46734, we are aiming to make the default size 40px size, and in #43741, there is
__next40pxDefaultSizeproperty for that purpose. Additionally, the vertical padding was adjusted to align the height with the existing pagination area.Screenshots or screencast
Has no unsaved entity
Before
After
Has unsaved entity
Before
After