Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Update mobile iOS Ruby version to from 2.7.4 to 3.2.2. #54897

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

derekblank
Copy link
Member

@derekblank derekblank commented Sep 28, 2023

What?

Bumps the iOS Ruby version to 3.2.2.

Related:

Why?

The WPiOS Ruby version was updated to 3.2.2 in wordpress-mobile/WordPress-iOS#21498.

How?

Updates packages/react-native-editor/ios/.ruby-version to 3.2.2.

Testing Instructions

rbenv install 3.2.2 should run successfully.

@derekblank derekblank added [Type] Task Issues or PRs that have been broken down into an individual action to take Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Sep 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Flaky tests detected in 6f1483b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6386826801
📝 Reported issues:

@derekblank derekblank requested a review from mokagio October 2, 2023 07:09
@geriux geriux self-requested a review October 2, 2023 08:04
@geriux
Copy link
Member

geriux commented Oct 2, 2023

Hey @derekblank 👋 thanks for updating this!

I was able to run the demo app successfully locally 🚀

This branch doesn't have the latest changes that are in the trunk branch, which enables Hermes but I don't think this change would affect that.

I would recommend updating the ruby version for the XCFramework as well, I saw there is a PR to do that here but some CI checks failed. Maybe it's worth checking what's causing that failure and updating both the demo app and the XCFramework at the same time. What do you think?

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

My GitHub shows a beta thing that does not look related to the changes in this PR, but I thought worth surfacing:

image

@derekblank
Copy link
Member Author

Looking good.

My GitHub shows a beta thing that does not look related to the changes in this PR, but I thought worth surfacing:

image

Thanks for the review @mokagio - I believe this error you're seeing was related to a flaky E2E test failure that I restarted (and now looks to be succeeding).

@derekblank
Copy link
Member Author

Hey @derekblank 👋 thanks for updating this!

I was able to run the demo app successfully locally 🚀

This branch doesn't have the latest changes that are in the trunk branch, which enables Hermes but I don't think this change would affect that.

I would recommend updating the ruby version for the XCFramework as well, I saw there is a PR to do that here but some CI checks failed. Maybe it's worth checking what's causing that failure and updating both the demo app and the XCFramework at the same time. What do you think?

Thanks for pointing out the existing Gutenberg Mobile Ruby 3.2.2 PR that @SiobhyB had started, @geriux! I made some updates to that PR, and the CI now appears to be passing. Additionally, I merged Gutenberg trunk with this PR in order to incorporate the Hermes changes. While Gio has already approved this Gutenberg PR, I added you as a reviewer to the Gutenberg Mobile PR just to check if there were any further changes needed there. If not, feel free to approve and merge both PRs to update the Ruby version for the Demo app and XCFramework at the same time.

@SiobhyB
Copy link
Contributor

SiobhyB commented Oct 3, 2023

Thanks for pointing out the existing wordpress-mobile/gutenberg-mobile#6180 that @SiobhyB had started, @geriux!

I just wanted to chime in to say thank you for picking that up! I had begun that PR just before the meetup and it slipped off my radar, I appreciate you both being so proactive and picking it up again 🙇‍♀️

@derekblank derekblank merged commit e6cd551 into trunk Oct 4, 2023
49 checks passed
@derekblank derekblank deleted the rnmobile/update-ruby-version branch October 4, 2023 03:12
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants