-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Update mobile iOS Ruby version to from 2.7.4 to 3.2.2. #54897
Conversation
Flaky tests detected in 6f1483b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6386826801
|
Hey @derekblank 👋 thanks for updating this! I was able to run the demo app successfully locally 🚀 This branch doesn't have the latest changes that are in the I would recommend updating the ruby version for the XCFramework as well, I saw there is a PR to do that here but some CI checks failed. Maybe it's worth checking what's causing that failure and updating both the demo app and the XCFramework at the same time. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @mokagio - I believe this error you're seeing was related to a flaky E2E test failure that I restarted (and now looks to be succeeding). |
Thanks for pointing out the existing Gutenberg Mobile Ruby 3.2.2 PR that @SiobhyB had started, @geriux! I made some updates to that PR, and the CI now appears to be passing. Additionally, I merged Gutenberg |
I just wanted to chime in to say thank you for picking that up! I had begun that PR just before the meetup and it slipped off my radar, I appreciate you both being so proactive and picking it up again 🙇♀️ |
What?
Bumps the iOS Ruby version to 3.2.2.
Related:
Why?
The WPiOS Ruby version was updated to 3.2.2 in wordpress-mobile/WordPress-iOS#21498.
How?
Updates
packages/react-native-editor/ios/.ruby-version
to 3.2.2.Testing Instructions
rbenv install 3.2.2
should run successfully.