Change ruby version to 3.2.2 #21498
Merged
Change ruby version to 3.2.2 #21498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21498-17ec957 | |
| Version | 23.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 17ec957 | |
| App Center Build | WPiOS - One-Offs #7007 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21498-17ec957 | |
| Version | 23.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 17ec957 | |
| App Center Build | jetpack-installable-builds #6051 |
crazytonyli
force-pushed
the
migrate-to-ruby-3
branch
from
7662b12 to
69ef75b
Compare
crazytonyli
force-pushed
the
migrate-to-ruby-3
branch
from
69ef75b to
17ec957
Compare
mokagio
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
I'm game for merging and addressing any Ruby issue that may arise.
I don't think it's worth trying to test them ahead of time, e.g. with a dummy release. I also think that, unless the issue turns out to be huge and expensive to fix, we'll be better off fixing them as soon as they come rather than reverting. Otherwise, we're only pushing the cost of fixing the issue to the future.
|
@mokagio Feel free to ping me if there is any issue 😃 |
mokagio
added a commit
that referenced
this pull request
Sep 11, 2023
17ec957 (#21498) switched the expected Ruby version to 3.x (🎉) Our Ruby linting automation only runs on diffed files so it didn't catch new violations that arose from the migration. The only reason I noticed, actually was because I just happened to modify the `Podfile` in 8df0aa0 (#21344) and got a CI failure.
4 tasks
mokagio
added a commit
that referenced
this pull request
Sep 11, 2023
17ec957 (#21498) switched the expected Ruby version to 3.x (🎉) Our Ruby linting automation only runs on diffed files so it didn't catch new violations that arose from the migration. The only reason I noticed, actually was because I just happened to modify the `Podfile` in 8df0aa0 (#21344) and got a CI failure.
2 tasks
mokagio
added a commit
that referenced
this pull request
Sep 15, 2023
17ec957 (#21498) switched the expected Ruby version to 3.x (🎉) Our Ruby linting automation only runs on diffed files so it didn't catch new violations that arose from the migration. The only reason I noticed, actually was because I just happened to modify the `Podfile` in 8df0aa0 (#21344) and got a CI failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.7.4 has reached end of life and it's about time that we migrate our Ruby toolings to Ruby 3.
Risk
The only risk I can see is there is a small chance that release tasks (that rely on release-toolkit) may break on Ruby 3, which we can't test at PR stage. But if that does happen and it's difficult to solve it properly, we can revert back to Ruby 2.7.4 by changing
.ruby-versionfile (or revert the only comment in this PR).Regression Notes
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A