Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing flow: preserve block when merging into empty paragraph #55134

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Oct 6, 2023

What?

Fixes #16436.

Why?

When merging a heading into an empty paragraph, the heading should be preserved and the paragraph removed.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Size Change: +1.14 kB (0%)

Total Size: 1.65 MB

Filename Size Change
build/block-editor/index.min.js 218 kB +537 B (0%)
build/components/index.min.js 249 kB +607 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 964 B
build/annotations/index.min.js 2.71 kB
build/api-fetch/index.min.js 2.29 kB
build/autop/index.min.js 2.11 kB
build/blob/index.min.js 461 B
build/block-directory/index.min.js 7.07 kB
build/block-directory/style-rtl.css 1.04 kB
build/block-directory/style.css 1.04 kB
build/block-editor/content-rtl.css 4.28 kB
build/block-editor/content.css 4.27 kB
build/block-editor/default-editor-styles-rtl.css 403 B
build/block-editor/default-editor-styles.css 403 B
build/block-editor/style-rtl.css 15.6 kB
build/block-editor/style.css 15.6 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 90 B
build/block-library/blocks/archives/style.css 90 B
build/block-library/blocks/audio/editor-rtl.css 150 B
build/block-library/blocks/audio/editor.css 150 B
build/block-library/blocks/audio/style-rtl.css 122 B
build/block-library/blocks/audio/style.css 122 B
build/block-library/blocks/audio/theme-rtl.css 138 B
build/block-library/blocks/audio/theme.css 138 B
build/block-library/blocks/avatar/editor-rtl.css 116 B
build/block-library/blocks/avatar/editor.css 116 B
build/block-library/blocks/avatar/style-rtl.css 104 B
build/block-library/blocks/avatar/style.css 104 B
build/block-library/blocks/block/editor-rtl.css 305 B
build/block-library/blocks/block/editor.css 305 B
build/block-library/blocks/button/editor-rtl.css 587 B
build/block-library/blocks/button/editor.css 587 B
build/block-library/blocks/button/style-rtl.css 633 B
build/block-library/blocks/button/style.css 632 B
build/block-library/blocks/buttons/editor-rtl.css 337 B
build/block-library/blocks/buttons/editor.css 337 B
build/block-library/blocks/buttons/style-rtl.css 332 B
build/block-library/blocks/buttons/style.css 332 B
build/block-library/blocks/calendar/style-rtl.css 239 B
build/block-library/blocks/calendar/style.css 239 B
build/block-library/blocks/categories/editor-rtl.css 113 B
build/block-library/blocks/categories/editor.css 112 B
build/block-library/blocks/categories/style-rtl.css 124 B
build/block-library/blocks/categories/style.css 124 B
build/block-library/blocks/code/editor-rtl.css 53 B
build/block-library/blocks/code/editor.css 53 B
build/block-library/blocks/code/style-rtl.css 121 B
build/block-library/blocks/code/style.css 121 B
build/block-library/blocks/code/theme-rtl.css 124 B
build/block-library/blocks/code/theme.css 124 B
build/block-library/blocks/columns/editor-rtl.css 108 B
build/block-library/blocks/columns/editor.css 108 B
build/block-library/blocks/columns/style-rtl.css 421 B
build/block-library/blocks/columns/style.css 421 B
build/block-library/blocks/comment-author-avatar/editor-rtl.css 125 B
build/block-library/blocks/comment-author-avatar/editor.css 125 B
build/block-library/blocks/comment-content/style-rtl.css 92 B
build/block-library/blocks/comment-content/style.css 92 B
build/block-library/blocks/comment-template/style-rtl.css 199 B
build/block-library/blocks/comment-template/style.css 198 B
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 123 B
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B
build/block-library/blocks/comments-pagination/editor-rtl.css 222 B
build/block-library/blocks/comments-pagination/editor.css 209 B
build/block-library/blocks/comments-pagination/style-rtl.css 235 B
build/block-library/blocks/comments-pagination/style.css 231 B
build/block-library/blocks/comments-title/editor-rtl.css 75 B
build/block-library/blocks/comments-title/editor.css 75 B
build/block-library/blocks/comments/editor-rtl.css 840 B
build/block-library/blocks/comments/editor.css 839 B
build/block-library/blocks/comments/style-rtl.css 637 B
build/block-library/blocks/comments/style.css 636 B
build/block-library/blocks/cover/editor-rtl.css 647 B
build/block-library/blocks/cover/editor.css 650 B
build/block-library/blocks/cover/style-rtl.css 1.7 kB
build/block-library/blocks/cover/style.css 1.69 kB
build/block-library/blocks/details/editor-rtl.css 65 B
build/block-library/blocks/details/editor.css 65 B
build/block-library/blocks/details/style-rtl.css 98 B
build/block-library/blocks/details/style.css 98 B
build/block-library/blocks/embed/editor-rtl.css 293 B
build/block-library/blocks/embed/editor.css 293 B
build/block-library/blocks/embed/style-rtl.css 410 B
build/block-library/blocks/embed/style.css 410 B
build/block-library/blocks/embed/theme-rtl.css 138 B
build/block-library/blocks/embed/theme.css 138 B
build/block-library/blocks/file/editor-rtl.css 316 B
build/block-library/blocks/file/editor.css 316 B
build/block-library/blocks/file/style-rtl.css 311 B
build/block-library/blocks/file/style.css 312 B
build/block-library/blocks/file/view.min.js 321 B
build/block-library/blocks/footnotes/style-rtl.css 201 B
build/block-library/blocks/footnotes/style.css 199 B
build/block-library/blocks/form-input/editor-rtl.css 229 B
build/block-library/blocks/form-input/editor.css 228 B
build/block-library/blocks/form-input/style-rtl.css 343 B
build/block-library/blocks/form-input/style.css 343 B
build/block-library/blocks/form-submission-notification/editor-rtl.css 343 B
build/block-library/blocks/form-submission-notification/editor.css 342 B
build/block-library/blocks/form-submit-button/style-rtl.css 69 B
build/block-library/blocks/form-submit-button/style.css 69 B
build/block-library/blocks/form/view.min.js 452 B
build/block-library/blocks/freeform/editor-rtl.css 2.61 kB
build/block-library/blocks/freeform/editor.css 2.61 kB
build/block-library/blocks/gallery/editor-rtl.css 957 B
build/block-library/blocks/gallery/editor.css 962 B
build/block-library/blocks/gallery/style-rtl.css 1.55 kB
build/block-library/blocks/gallery/style.css 1.55 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 654 B
build/block-library/blocks/group/editor.css 654 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 189 B
build/block-library/blocks/heading/style.css 189 B
build/block-library/blocks/html/editor-rtl.css 340 B
build/block-library/blocks/html/editor.css 341 B
build/block-library/blocks/image/editor-rtl.css 834 B
build/block-library/blocks/image/editor.css 833 B
build/block-library/blocks/image/style-rtl.css 1.48 kB
build/block-library/blocks/image/style.css 1.47 kB
build/block-library/blocks/image/theme-rtl.css 137 B
build/block-library/blocks/image/theme.css 137 B
build/block-library/blocks/image/view.min.js 1.91 kB
build/block-library/blocks/latest-comments/style-rtl.css 357 B
build/block-library/blocks/latest-comments/style.css 357 B
build/block-library/blocks/latest-posts/editor-rtl.css 213 B
build/block-library/blocks/latest-posts/editor.css 212 B
build/block-library/blocks/latest-posts/style-rtl.css 478 B
build/block-library/blocks/latest-posts/style.css 478 B
build/block-library/blocks/list/style-rtl.css 88 B
build/block-library/blocks/list/style.css 88 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 505 B
build/block-library/blocks/media-text/style.css 503 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 671 B
build/block-library/blocks/navigation-link/editor.css 672 B
build/block-library/blocks/navigation-link/style-rtl.css 103 B
build/block-library/blocks/navigation-link/style.css 103 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 299 B
build/block-library/blocks/navigation-submenu/editor.css 299 B
build/block-library/blocks/navigation/editor-rtl.css 2.26 kB
build/block-library/blocks/navigation/editor.css 2.26 kB
build/block-library/blocks/navigation/style-rtl.css 2.26 kB
build/block-library/blocks/navigation/style.css 2.25 kB
build/block-library/blocks/navigation/view.min.js 1.01 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 401 B
build/block-library/blocks/page-list/editor.css 401 B
build/block-library/blocks/page-list/style-rtl.css 175 B
build/block-library/blocks/page-list/style.css 175 B
build/block-library/blocks/paragraph/editor-rtl.css 235 B
build/block-library/blocks/paragraph/editor.css 235 B
build/block-library/blocks/paragraph/style-rtl.css 335 B
build/block-library/blocks/paragraph/style.css 335 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments-form/editor-rtl.css 96 B
build/block-library/blocks/post-comments-form/editor.css 96 B
build/block-library/blocks/post-comments-form/style-rtl.css 508 B
build/block-library/blocks/post-comments-form/style.css 508 B
build/block-library/blocks/post-date/style-rtl.css 61 B
build/block-library/blocks/post-date/style.css 61 B
build/block-library/blocks/post-excerpt/editor-rtl.css 71 B
build/block-library/blocks/post-excerpt/editor.css 71 B
build/block-library/blocks/post-excerpt/style-rtl.css 141 B
build/block-library/blocks/post-excerpt/style.css 141 B
build/block-library/blocks/post-featured-image/editor-rtl.css 588 B
build/block-library/blocks/post-featured-image/editor.css 586 B
build/block-library/blocks/post-featured-image/style-rtl.css 345 B
build/block-library/blocks/post-featured-image/style.css 345 B
build/block-library/blocks/post-navigation-link/style-rtl.css 215 B
build/block-library/blocks/post-navigation-link/style.css 214 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 409 B
build/block-library/blocks/post-template/style.css 408 B
build/block-library/blocks/post-terms/style-rtl.css 96 B
build/block-library/blocks/post-terms/style.css 96 B
build/block-library/blocks/post-time-to-read/style-rtl.css 69 B
build/block-library/blocks/post-time-to-read/style.css 69 B
build/block-library/blocks/post-title/style-rtl.css 100 B
build/block-library/blocks/post-title/style.css 100 B
build/block-library/blocks/preformatted/style-rtl.css 125 B
build/block-library/blocks/preformatted/style.css 125 B
build/block-library/blocks/pullquote/editor-rtl.css 135 B
build/block-library/blocks/pullquote/editor.css 135 B
build/block-library/blocks/pullquote/style-rtl.css 335 B
build/block-library/blocks/pullquote/style.css 335 B
build/block-library/blocks/pullquote/theme-rtl.css 168 B
build/block-library/blocks/pullquote/theme.css 168 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 221 B
build/block-library/blocks/query-pagination/editor.css 211 B
build/block-library/blocks/query-pagination/style-rtl.css 288 B
build/block-library/blocks/query-pagination/style.css 284 B
build/block-library/blocks/query-title/style-rtl.css 63 B
build/block-library/blocks/query-title/style.css 63 B
build/block-library/blocks/query/editor-rtl.css 486 B
build/block-library/blocks/query/editor.css 486 B
build/block-library/blocks/query/style-rtl.css 375 B
build/block-library/blocks/query/style.css 372 B
build/block-library/blocks/query/view.min.js 609 B
build/block-library/blocks/quote/style-rtl.css 222 B
build/block-library/blocks/quote/style.css 222 B
build/block-library/blocks/quote/theme-rtl.css 223 B
build/block-library/blocks/quote/theme.css 226 B
build/block-library/blocks/read-more/style-rtl.css 132 B
build/block-library/blocks/read-more/style.css 132 B
build/block-library/blocks/rss/editor-rtl.css 149 B
build/block-library/blocks/rss/editor.css 149 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 184 B
build/block-library/blocks/search/editor.css 184 B
build/block-library/blocks/search/style-rtl.css 613 B
build/block-library/blocks/search/style.css 613 B
build/block-library/blocks/search/theme-rtl.css 114 B
build/block-library/blocks/search/theme.css 114 B
build/block-library/blocks/search/view.min.js 471 B
build/block-library/blocks/separator/editor-rtl.css 146 B
build/block-library/blocks/separator/editor.css 146 B
build/block-library/blocks/separator/style-rtl.css 234 B
build/block-library/blocks/separator/style.css 234 B
build/block-library/blocks/separator/theme-rtl.css 194 B
build/block-library/blocks/separator/theme.css 194 B
build/block-library/blocks/shortcode/editor-rtl.css 329 B
build/block-library/blocks/shortcode/editor.css 329 B
build/block-library/blocks/site-logo/editor-rtl.css 760 B
build/block-library/blocks/site-logo/editor.css 760 B
build/block-library/blocks/site-logo/style-rtl.css 204 B
build/block-library/blocks/site-logo/style.css 204 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 116 B
build/block-library/blocks/site-title/editor.css 116 B
build/block-library/blocks/site-title/style-rtl.css 57 B
build/block-library/blocks/site-title/style.css 57 B
build/block-library/blocks/social-link/editor-rtl.css 184 B
build/block-library/blocks/social-link/editor.css 184 B
build/block-library/blocks/social-links/editor-rtl.css 682 B
build/block-library/blocks/social-links/editor.css 681 B
build/block-library/blocks/social-links/style-rtl.css 1.45 kB
build/block-library/blocks/social-links/style.css 1.45 kB
build/block-library/blocks/spacer/editor-rtl.css 359 B
build/block-library/blocks/spacer/editor.css 359 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 432 B
build/block-library/blocks/table/editor.css 432 B
build/block-library/blocks/table/style-rtl.css 646 B
build/block-library/blocks/table/style.css 645 B
build/block-library/blocks/table/theme-rtl.css 157 B
build/block-library/blocks/table/theme.css 157 B
build/block-library/blocks/tag-cloud/style-rtl.css 251 B
build/block-library/blocks/tag-cloud/style.css 253 B
build/block-library/blocks/template-part/editor-rtl.css 403 B
build/block-library/blocks/template-part/editor.css 403 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/style-rtl.css 111 B
build/block-library/blocks/term-description/style.css 111 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 99 B
build/block-library/blocks/verse/style.css 99 B
build/block-library/blocks/video/editor-rtl.css 552 B
build/block-library/blocks/video/editor.css 555 B
build/block-library/blocks/video/style-rtl.css 191 B
build/block-library/blocks/video/style.css 191 B
build/block-library/blocks/video/theme-rtl.css 139 B
build/block-library/blocks/video/theme.css 139 B
build/block-library/classic-rtl.css 179 B
build/block-library/classic.css 179 B
build/block-library/common-rtl.css 1.11 kB
build/block-library/common.css 1.11 kB
build/block-library/editor-elements-rtl.css 75 B
build/block-library/editor-elements.css 75 B
build/block-library/editor-rtl.css 12.4 kB
build/block-library/editor.css 12.4 kB
build/block-library/elements-rtl.css 54 B
build/block-library/elements.css 54 B
build/block-library/index.min.js 211 kB
build/block-library/reset-rtl.css 472 B
build/block-library/reset.css 472 B
build/block-library/style-rtl.css 14.4 kB
build/block-library/style.css 14.4 kB
build/block-library/theme-rtl.css 700 B
build/block-library/theme.css 705 B
build/block-serialization-default-parser/index.min.js 1.13 kB
build/block-serialization-spec-parser/index.min.js 2.87 kB
build/blocks/index.min.js 51.5 kB
build/commands/index.min.js 15.5 kB
build/commands/style-rtl.css 947 B
build/commands/style.css 942 B
build/components/style-rtl.css 11.9 kB
build/components/style.css 11.9 kB
build/compose/index.min.js 12.7 kB
build/core-commands/index.min.js 2.72 kB
build/core-data/index.min.js 70.6 kB
build/customize-widgets/index.min.js 12 kB
build/customize-widgets/style-rtl.css 1.51 kB
build/customize-widgets/style.css 1.5 kB
build/data-controls/index.min.js 651 B
build/data/index.min.js 8.78 kB
build/date/index.min.js 17.9 kB
build/deprecated/index.min.js 462 B
build/dom-ready/index.min.js 336 B
build/dom/index.min.js 4.68 kB
build/edit-post/classic-rtl.css 571 B
build/edit-post/classic.css 571 B
build/edit-post/index.min.js 35.6 kB
build/edit-post/style-rtl.css 7.89 kB
build/edit-post/style.css 7.88 kB
build/edit-site/index.min.js 203 kB
build/edit-site/style-rtl.css 14.1 kB
build/edit-site/style.css 14.1 kB
build/edit-widgets/index.min.js 17 kB
build/edit-widgets/style-rtl.css 4.84 kB
build/edit-widgets/style.css 4.84 kB
build/editor/index.min.js 45.9 kB
build/editor/style-rtl.css 3.58 kB
build/editor/style.css 3.58 kB
build/element/index.min.js 4.87 kB
build/escape-html/index.min.js 548 B
build/format-library/index.min.js 7.79 kB
build/format-library/style-rtl.css 577 B
build/format-library/style.css 577 B
build/hooks/index.min.js 1.57 kB
build/html-entities/index.min.js 454 B
build/i18n/index.min.js 3.61 kB
build/interactivity/index.min.js 11.4 kB
build/is-shallow-equal/index.min.js 535 B
build/keyboard-shortcuts/index.min.js 1.76 kB
build/keycodes/index.min.js 1.9 kB
build/list-reusable-blocks/index.min.js 2.21 kB
build/list-reusable-blocks/style-rtl.css 865 B
build/list-reusable-blocks/style.css 865 B
build/media-utils/index.min.js 2.92 kB
build/notices/index.min.js 964 B
build/nux/index.min.js 2.01 kB
build/nux/style-rtl.css 775 B
build/nux/style.css 771 B
build/patterns/index.min.js 3.7 kB
build/patterns/style-rtl.css 518 B
build/patterns/style.css 517 B
build/plugins/index.min.js 1.81 kB
build/preferences-persistence/index.min.js 1.85 kB
build/preferences/index.min.js 1.26 kB
build/primitives/index.min.js 994 B
build/priority-queue/index.min.js 1.52 kB
build/private-apis/index.min.js 972 B
build/react-i18n/index.min.js 631 B
build/react-refresh-entry/index.min.js 9.46 kB
build/react-refresh-runtime/index.min.js 6.78 kB
build/redux-routine/index.min.js 2.71 kB
build/reusable-blocks/index.min.js 2.73 kB
build/reusable-blocks/style-rtl.css 265 B
build/reusable-blocks/style.css 265 B
build/rich-text/index.min.js 10.2 kB
build/router/index.min.js 1.79 kB
build/server-side-render/index.min.js 1.96 kB
build/shortcode/index.min.js 1.4 kB
build/style-engine/index.min.js 1.98 kB
build/token-list/index.min.js 587 B
build/url/index.min.js 3.84 kB
build/vendors/inert-polyfill.min.js 2.48 kB
build/vendors/react-dom.min.js 41.8 kB
build/vendors/react.min.js 4.02 kB
build/viewport/index.min.js 967 B
build/warning/index.min.js 259 B
build/widgets/index.min.js 7.18 kB
build/widgets/style-rtl.css 1.18 kB
build/widgets/style.css 1.18 kB
build/wordcount/index.min.js 1.03 kB

compressed-size-action

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Flaky tests detected in 1171b18.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6455758261
📝 Reported issues:

@ellatrix ellatrix force-pushed the fix/merge-empty-default-block branch from d5b4224 to 3c8e1f7 Compare October 9, 2023 09:25
@@ -43,7 +43,7 @@ export function useDelete( props ) {
// an intentional user interaction distinguishing between Backspace and
// Delete to remove the empty field, but also to avoid merge & remove
// causing destruction of two fields (merge, then removed merged).
if ( onRemove && isEmpty( value ) && isReverse ) {
else if ( onRemove && isEmpty( value ) && isReverse ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change in practice, this condition else if ( onRemove && isEmpty( value ) && isReverse ) {is never executed right ? We pass an onMerge on the block list so if ( onMerge ) { will always be truth, if that's the case would it make sense to remove the condition?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all blocks may pass an onMerge function to RichText, they may only pass onRemove.

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes works well on the tests I did and the code looks good 👍

@ellatrix ellatrix merged commit eb77e48 into trunk Oct 9, 2023
50 checks passed
@ellatrix ellatrix deleted the fix/merge-empty-default-block branch October 9, 2023 17:27
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 9, 2023
geriux pushed a commit that referenced this pull request Nov 24, 2023
geriux pushed a commit that referenced this pull request Nov 28, 2023
* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG
geriux pushed a commit that referenced this pull request Nov 29, 2023
* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG
geriux pushed a commit that referenced this pull request Nov 30, 2023
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

---------

Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
fluiddot added a commit that referenced this pull request Dec 5, 2023
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

* [RNMobile] Fixes a crash on pasting MS Word list markup (#56653)

* Add polyfill for Element.prototype.remove

* Enable unit tests of `raw-handling` API filter `ms-list-converter`

* Update `react-native-editor` changelog

* [RNMobile] Fix issue related to receiving undefined ref in text color format (#56686)

* Fix issue related to receiving undefined ref in text color format

In rare cases, `TextColorEdit` might receive the `RichText` ref as undefined. This ref is used to get the background color of the text and use it in the toolbar button.

* Update `react-native-editor` changelog

* Add test to cover undefined `contentRef` case

* Correct typo in `changelog`

* [RNMobile] Fix HTML to blocks conversion when no transformations are available (#56723)

* Add native workaround for HTML block in `htmlToBlocks`

* Add raw handling tests

This file is a clone of the same `blocks-raw-handling.js` file located in `gutenberg/test/integration`. The reason for the separation is that several of the test cases fail in the native version. For now, we are going to skip them, but we'd need to work on them in the future.
Once all issues in tests are addressed, we'll remove this file in favor of the original one.

* Update blocks raw handling test snapshot with original values

* Disable more pasteHandler test cases due to not matching test snapshot

* Comment obsolete snapshots of blocks raw handling tests

The reason for commenting them instead of removing is that, in the future, we'll restore them once we address the failing test cases.

* RichText (native): remove HTML check in getFormatColors (#56684)

* Mobile - Global Styles - Fix issue with custom color variables not being parsed (#56752)

* [RNMobile] Address `NullPointerException` crash in `AztecHeadingSpan` (#56757)

Address rare cases where a null value is passed to a heading block, causing a crash.

* Release script: Update react-native-editor version to 1.109.2

* Release script: Update CHANGELOG for version 1.109.2

* Release script: Update podfile

---------

Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
Co-authored-by: Siobhan Bamber <siobhan@automattic.com>
derekblank pushed a commit that referenced this pull request Dec 7, 2023
* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG
derekblank pushed a commit that referenced this pull request Dec 7, 2023
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

---------

Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
SiobhyB pushed a commit that referenced this pull request Dec 14, 2023
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

* [RNMobile] Fixes a crash on pasting MS Word list markup (#56653)

* Add polyfill for Element.prototype.remove

* Enable unit tests of `raw-handling` API filter `ms-list-converter`

* Update `react-native-editor` changelog

* [RNMobile] Fix issue related to receiving undefined ref in text color format (#56686)

* Fix issue related to receiving undefined ref in text color format

In rare cases, `TextColorEdit` might receive the `RichText` ref as undefined. This ref is used to get the background color of the text and use it in the toolbar button.

* Update `react-native-editor` changelog

* Add test to cover undefined `contentRef` case

* Correct typo in `changelog`

* [RNMobile] Fix HTML to blocks conversion when no transformations are available (#56723)

* Add native workaround for HTML block in `htmlToBlocks`

* Add raw handling tests

This file is a clone of the same `blocks-raw-handling.js` file located in `gutenberg/test/integration`. The reason for the separation is that several of the test cases fail in the native version. For now, we are going to skip them, but we'd need to work on them in the future.
Once all issues in tests are addressed, we'll remove this file in favor of the original one.

* Update blocks raw handling test snapshot with original values

* Disable more pasteHandler test cases due to not matching test snapshot

* Comment obsolete snapshots of blocks raw handling tests

The reason for commenting them instead of removing is that, in the future, we'll restore them once we address the failing test cases.

* RichText (native): remove HTML check in getFormatColors (#56684)

* Mobile - Global Styles - Fix issue with custom color variables not being parsed (#56752)

* [RNMobile] Address `NullPointerException` crash in `AztecHeadingSpan` (#56757)

Address rare cases where a null value is passed to a heading block, causing a crash.

* Release script: Update react-native-editor version to 1.109.2

* Release script: Update CHANGELOG for version 1.109.2

* Release script: Update podfile

* Release script: Update react-native-editor version to 1.109.3

* Release script: Update CHANGELOG for version 1.109.3

* Release script: Update podfile

* Mobile - Fix having the default font sizes when there are theme font sizes available

* Update CHANGELOG entry

---------

Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
* Release script: Update react-native-editor version to 1.109.0

* Release script: Update CHANGELOG for version 1.109.0

* Release script: Update podfile

* Update `react-native-editor` changelog

* Update `react-native-editor` changelog

* Mobile - Fix issue when backspacing in an empty Paragraph block (#56496)

* Bring changes from #55134 to the mobile code

* Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks.

* Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block

* Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block

* Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput

* Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing

* Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button

* Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge

* Update CHANGELOG

* Release script: Update react-native-editor version to 1.109.1

* Release script: Update CHANGELOG for version 1.109.1

* Release script: Update podfile

* [RNMobile] Fixes a crash on pasting MS Word list markup (#56653)

* Add polyfill for Element.prototype.remove

* Enable unit tests of `raw-handling` API filter `ms-list-converter`

* Update `react-native-editor` changelog

* [RNMobile] Fix issue related to receiving undefined ref in text color format (#56686)

* Fix issue related to receiving undefined ref in text color format

In rare cases, `TextColorEdit` might receive the `RichText` ref as undefined. This ref is used to get the background color of the text and use it in the toolbar button.

* Update `react-native-editor` changelog

* Add test to cover undefined `contentRef` case

* Correct typo in `changelog`

* [RNMobile] Fix HTML to blocks conversion when no transformations are available (#56723)

* Add native workaround for HTML block in `htmlToBlocks`

* Add raw handling tests

This file is a clone of the same `blocks-raw-handling.js` file located in `gutenberg/test/integration`. The reason for the separation is that several of the test cases fail in the native version. For now, we are going to skip them, but we'd need to work on them in the future.
Once all issues in tests are addressed, we'll remove this file in favor of the original one.

* Update blocks raw handling test snapshot with original values

* Disable more pasteHandler test cases due to not matching test snapshot

* Comment obsolete snapshots of blocks raw handling tests

The reason for commenting them instead of removing is that, in the future, we'll restore them once we address the failing test cases.

* RichText (native): remove HTML check in getFormatColors (#56684)

* Mobile - Global Styles - Fix issue with custom color variables not being parsed (#56752)

* [RNMobile] Address `NullPointerException` crash in `AztecHeadingSpan` (#56757)

Address rare cases where a null value is passed to a heading block, causing a crash.

* Release script: Update react-native-editor version to 1.109.2

* Release script: Update CHANGELOG for version 1.109.2

* Release script: Update podfile

* Release script: Update react-native-editor version to 1.109.3

* Release script: Update CHANGELOG for version 1.109.3

* Release script: Update podfile

* Mobile - Fix having the default font sizes when there are theme font sizes available

* Update CHANGELOG entry

---------

Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing flow: hitting backspace causes block to lose heading when prior block is empty
2 participants