Writing flow: Backspace at beginning of first paragraph block prevents block from being deleted #56329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
fix/empty-paragraph-backspace
branch
from
ceb00fb to
7ec534a
Compare
|
Size Change: +68 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Bug
t-hamano
requested review from
kevin940726,
Mamaduka and
ellatrix
as code owners
t-hamano
force-pushed
the
fix/empty-paragraph-backspace
branch
from
7ec534a to
a253d0c
Compare
…s block from being deleted
t-hamano
force-pushed
the
fix/empty-paragraph-backspace
branch
from
a253d0c to
a8b1912
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
reviewed
Mar 3, 2024
| @@ -451,8 +451,17 @@ const applyWithDispatch = withDispatch( ( dispatch, ownProps, registry ) => { | |||
| } | |||
|
|
|||
| moveFirstItemUp( rootClientId ); | |||
| } else { | |||
| removeBlock( clientId ); | |||
There was a problem hiding this comment.
Should we maybe just not do anything? I'm not sure if pressing Backspace at the start of a heading should convert it to a paragraph? Are there any editors that do this?
There was a problem hiding this comment.
Google Docs and MS Word don't seem to transform a heading into a paragraph. Regarding Notion, it seems to transform a heading into a paragraph.
9cd90d08815c9c736a142187f7cb9fcb.mp4
Personally, I like the current behavior of the Backspace key. If the backspace key does nothing, we will need to transform the existing heading into a paragraph or delete it in order to start a new article again from a paragraph. This seems a little cumbersome to me.
ellatrix
reviewed
Mar 30, 2024
ellatrix
approved these changes
Apr 1, 2024
ramonjd
changed the title
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…ts block from being deleted (WordPress#56329) * Writing flow: Backspace at beginning of first paragraph block prevents block from being deleted * Use replaceBlocks Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56303
Related to #55134
What?
This PR fixes an issue where pressing the backspace key at the beginning of a paragraph block with content causes the block to be deleted.
Before
before.mp4
After
after.mp4
Why?
I think the current implementation deletes a block when you press the backspace key at the beginning of the first block. This is a problem if the paragraph or heading already has content.
How?
I updated the logic to have the following behavior when the BACKSPACE key is pressed in the first block. I think this is expected behavior.
Testing Instructions