Use contextual toolbar in the zoom out mode #56808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Experimental
|
Size Change: +11 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Dec 6, 2023
talldan
merged commit 0bc014c
into
try/zoomed-out-mode-experiments
55 of 56 checks passed
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #56806. Use contextual toolbar in the zoom-out mode.
Why?
Allows reordering/deleting blocks in the zoom-out mode, as they are some core features we want to support in that mode. We can still use the navigation toolbar but then we'll need to add the "Delete" action back. Using the contextual toolbar is just easier at this stage.
How?
Tweak the conditions to also allow contextual toolbar in the zoom-out mode.
Testing Instructions
Screenshots or screencast
Kapture.2023-12-06.at.16.34.44.mp4