-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out the Curating the Editor Experience doc into its own How-to Guides section #57289
Conversation
Flaky tests detected in 5f4ad6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7281194916
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but left two minor comments :) Thank you for moving this forward.
@@ -0,0 +1,210 @@ | |||
# theme.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find the lower case t to throw me off here. Any reason not to capitalize?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested across different systems, but I'd always err on the side of preserving the correct case for filenames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested across different systems, but I'd always err on the side of preserving the correct case for filenames.
Yeah, we are doing the same thing with other common filenames like block.json, functions.php, etc. That said, we do need to comb through the Handbook and standardize this.
🥳 Thanks for getting this done! |
This PR is an initial implementation of the concept outlined in #56170.
I have taken the Curating the Editor Experience doc and made it its own section in How-to Guides. I have then broken the doc up into five additional docs.
The last section is a bit of a catch-all that covers miscellaneous curation techniques not covered in the other sections. I did add some new content here about disabling block variations and styles.
Let me know what you think of this initial iteration. The next step will be to go through each sub-doc and overhaul the content with additional information, new examples, etc.