-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the slug for the theme.json doc to avoid conflicts #57410
Conversation
I feel it's better if the slug is based on the page title. The title of the page added in #57289 is "Global Settings & Styles (theme.json)", but the page title and slug are In other words, the classification is as follows.
Reference: Similar page in the theme handbook |
Yeah, I do like that better. Good call @t-hamano. This will require a new redirect to be put in place. I will get this PR and the redirect PR put together today. |
@t-hamano I have updated this PR based on your suggested approach. I have also created the redirect PR here: WordPress/wporg-developer#457. This PR should be merged at the same time the redirect PR is put in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few suggestions regarding links, and overall things seem fine 👍
In addition to this, I suspect that the link below is also not working properly.
Link support has been made stable as part of WordPress 5.8. It's `false` by default and themes can enable it via the [theme.json file](./theme-json.md): |
Perhaps /docs/how-to-guides/curating-the-editor-experience/theme-json.md
rather than ./theme-json.md
?
packages/style-engine/docs/using-the-style-engine-with-block-supports.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
…upports.md Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Good catch, missed that one. All updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
It turns out that each doc slug needs to be unique. A new theme.json doc was created in #57289 and the slug was simply
theme-json
, which already existed. Therefore, the new doc was not synced to the Handbook.This PR modifies the slug totheme-json-configurations
, thus making it unique.Edit: Following the comment below, I have updated the approach in this PR to instead change the slug of the Global Settings & Styles doc. While updating that doc, I also removed an unnecessary TOC.
Warning
I have also created the redirect PR here: WordPress/wporg-developer#457. This PR should be merged at the same time the redirect PR is put in place.