-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Expand E2E test utilities #59214
Conversation
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
Flaky tests detected in 5dea1345f90138db0b2c0e296284a1daf0c08c03. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8012648742
|
b0dd8e2
to
5dea134
Compare
Simplify rendering a smaller Gallery block.
Simplify selecting a block via tapping it.
Some blocks contain nested pressables that need to be avoided for certain test cases.
Allowing composing offsets based upon the block dimensions, making it easier to target, e.g., the top-left corner.
Restructure the utility to reuse the existing `getBlockAtPosition` utility, encouraging composition of utilities rather than duplication.
5dea134
to
b5324fc
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice addition of the selectBlock
util 🚀
Related
What?
Expand mobile end-to-end (E2E) test utilities.
Why?
Enable additional visual test case in the
gutenberg-mobile
repository.How?
selectBlockByType
utilityselectBlockByType
allows offsetting tap positionTesting Instructions
N/A, no user-facing changes.
Testing Instructions for Keyboard
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.