Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add dark mode tests #6653

Merged
merged 6 commits into from
Feb 26, 2024
Merged

test: Add dark mode tests #6653

merged 6 commits into from
Feb 26, 2024

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Feb 20, 2024 •
edited
Loading

Related

Description

Automate manual test cases for dark mode.

  • Add Gallery block dark mode test case
  • Add Shortcode block dark mode test case
  • Add Media & Text block dark mode test case
  • Add Quote block dark mode test case

To test: N/A, no user-facing changes.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added Testing Anything related to automated tests [Type] Task labels Feb 20, 2024
dcalhoun added a commit to wordpress-mobile/test-cases that referenced this pull request Feb 20, 2024
@dcalhoun
docs: Remove dark mode test cases
922e8c1 
These were automated in
wordpress-mobile/gutenberg-mobile#6653.
This was referenced Feb 20, 2024
Merged
Merged
@dcalhoun dcalhoun force-pushed the test/add-dark-mode-tests branch 4 times, most recently from 957ea33 to fa87669 Compare February 21, 2024 17:11
@dcalhoun dcalhoun force-pushed the test/add-dark-mode-tests branch from 3c89654 to 31e4994 Compare February 23, 2024 19:01
@dcalhoun
test: Repurpose selectBlockByType to selectBlock
f8fed4a 
Restructure the utility to reuse the existing `getBlockAtPosition`
utility, encouraging composition of utilities rather than duplication.
@dcalhoun dcalhoun force-pushed the test/add-dark-mode-tests branch from 31e4994 to f8fed4a Compare February 23, 2024 19:03
@dcalhoun dcalhoun marked this pull request as ready for review February 23, 2024 19:42
@dcalhoun dcalhoun requested a review from geriux February 23, 2024 19:42
geriux
geriux approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All CI checks passed correctly ✅ 🚀

@dcalhoun dcalhoun enabled auto-merge February 26, 2024 12:18
dcalhoun added a commit to wordpress-mobile/test-cases that referenced this pull request Feb 26, 2024
@dcalhoun
docs: Remove dark mode test cases (#168)
024662b 
* docs: Remove dark mode test cases

These were automated in
wordpress-mobile/gutenberg-mobile#6653.

* docs: Remove unused image resources
@dcalhoun dcalhoun merged commit 0fbf08f into trunk Feb 26, 2024
17 of 20 checks passed
@dcalhoun dcalhoun deleted the test/add-dark-mode-tests branch February 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
Testing Anything related to automated tests [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcalhoun @geriux