-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lib-font credits and license in source code #60973
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +21 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Flaky tests detected in 5c80898. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8791088164
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, @matiasbenedetto. Additions look good to me and are in line with other licenses like serialize.js 👍
This PR has been added to the 6.6 Editor tasks board, but I noticed that GitHub Actions is down. Therefore, I updated this PR and started GitHub Actions again. I would be happy if you could merge it once it has gone through all the GitHub Actions. |
What?
Add lib-font credits and license in the source code.
Until we find a way to install the package as an npm dependency the relevant package files were copied to the Gutenberg codebase.
Why?
It is appropriate to add the package credits following examples like serialize.js.
How?
Adding the credits in the same format as other js files in the codebase.
Testing Instructions
No code changes were added. Only credits and license info as comments.