Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] Ensure that a store can be subscribed to before it is initialized #59899

Closed
github-actions bot opened this issue Mar 15, 2024 · 3 comments · Fixed by #61359 or #62571
Closed

[Flaky Test] Ensure that a store can be subscribed to before it is initialized #59899

github-actions bot opened this issue Mar 15, 2024 · 3 comments · Fixed by #61359 or #62571
Assignees
@sirreal
Labels
[Status] In Progress Tracking issues with work in progress [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Mar 15, 2024 •
edited
Loading

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

Ensure that a store can be subscribed to before it is initialized

Test path

/test/e2e/specs/interactivity/deferred-store.spec.ts

Errors

[2024-03-15T11:26:26.510Z] Test passed after 1 failed attempt on trunk.
[2024-03-15T12:36:00.862Z] Test passed after 1 failed attempt on trunk.
[2024-03-15T15:35:51.086Z] Test passed after 1 failed attempt on security-upgrades.
[2024-03-20T13:58:25.811Z] Test passed after 1 failed attempt on fix/rich-text-identifiers.
[2024-03-20T16:33:35.346Z] Test passed after 2 failed attempts on upgrade/simple-git.
[2024-03-20T19:36:12.500Z] Test passed after 2 failed attempts on upgrade/simple-git.
[2024-03-21T08:13:23.558Z] Test passed after 2 failed attempts on try/social-icons-url-to-variation-matcher.
[2024-03-21T13:41:19.365Z] Test passed after 1 failed attempt on trunk.
[2024-03-22T10:21:30.873Z] Test passed after 2 failed attempts on polish/block-card.
[2024-03-22T16:47:27.207Z] Test passed after 2 failed attempts on try-vertical-toolbar-zoomed-out.
[2024-03-25T16:54:37.481Z] Test passed after 1 failed attempt on trunk.
[2024-03-26T17:35:36.438Z] Test passed after 2 failed attempts on trunk.
[2024-03-27T14:45:25.500Z] Test passed after 1 failed attempt on add/e2e-test-for-font-lib-theme-style-variations.
[2024-03-27T18:24:36.398Z] Test passed after 1 failed attempt on update/template-reset-language.
[2024-03-28T18:39:48.950Z] Test passed after 2 failed attempts on update/template-reset-language.
[2024-04-03T08:20:23.780Z] Test passed after 1 failed attempt on trunk.
[2024-04-03T09:35:52.170Z] Test passed after 1 failed attempt on update/mobile-page-pages-show-content-frame.
[2024-04-08T16:39:53.389Z] Test passed after 2 failed attempts on trunk.
[2024-04-08T19:04:13.066Z] Test passed after 1 failed attempt on fix/nav-logic-on-mount.
[2024-04-11T07:03:09.606Z] Test passed after 1 failed attempt on update/post-url-component.
[2024-04-11T07:04:53.879Z] Test passed after 2 failed attempts on add/grid-interactivity-positioning.
[2024-04-14T12:51:09.811Z] Test passed after 1 failed attempt on trunk.
[2024-04-15T09:04:10.738Z] Test passed after 2 failed attempts on trunk.
[2024-04-15T12:19:30.606Z] Test passed after 2 failed attempts on add/support-starter-page-content-site-editor.
[2024-04-17T11:03:34.020Z] Test passed after 1 failed attempt on trunk.
[2024-04-17T12:02:39.424Z] Test passed after 2 failed attempts on update/allow-overrides-button-ui.
[2024-04-18T15:43:00.363Z] Test passed after 1 failed attempt on fix/stable-ignore-directives.
[2024-04-22T08:09:36.877Z] Test passed after 1 failed attempt on update/unify-more-menu.
[2024-04-22T21:43:49.813Z] Test passed after 2 failed attempts on add/lib-font-credits.
[2024-04-23T18:48:52.039Z] Test passed after 1 failed attempt on add/duplicate-post-action.
[2024-04-30T08:02:13.102Z] Test passed after 1 failed attempt on update/content-only-menu-desc.
[2024-04-30T13:16:44.372Z] Test passed after 2 failed attempts on cleanup/editor.
[2024-05-01T16:52:43.387Z] Test passed after 2 failed attempts on rollback/setup-node-update.
[2024-05-02T10:40:49.382Z] Test passed after 2 failed attempts on add-pattern-inserter.
[2024-05-02T12:48:20.251Z] Test passed after 1 failed attempt on enhancement/shorcut-selected-blocks-to-group.
[2024-05-02T19:39:41.024Z] Test passed after 2 failed attempts on update/tests-line-height-control.
[2024-05-28T13:08:50.263Z] Test passed after 1 failed attempt on trunk.
[2024-06-14T07:13:33.020Z] Test passed after 1 failed attempt on add/background-global-styles-panel-for-blocks. 
Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

Locator: getByTestId('result')
Expected string: ""
Received string: "Hello, world!"
Call log:
  - expect.toHaveText with timeout 5000ms
  - waiting for getByTestId('result')
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"
  -   locator resolved to <span data-testid="result" data-wp-text="state.reverse…>Hello, world!</span>
  -   unexpected value "Hello, world!"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/deferred-store.spec.ts:23:31
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Mar 15, 2024
github-actions bot referenced this issue Mar 15, 2024
@oandregal @youknowriad
DataViews: make list layout stable (#59858)
c187e22 
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
github-actions bot referenced this issue Mar 15, 2024
Mobile Release v1.115.0 (#59876)
979770f 
* Release script: Update react-native-editor version to 1.115.0

* Release script: Update CHANGELOG for version 1.115.0

* Release script: Update podfile

Co-authored-by: geriux <geriux@git.wordpress.org>
Co-authored-by: twstokes <twstokes@git.wordpress.org>
This was referenced Mar 15, 2024
Merged
Merged
Merged
Open
github-actions bot referenced this issue Mar 21, 2024
@scruffian
Pattern Shuffling: Don't assume that patterns have categories (#60070)
c657927 
Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: arthur791004 <arthur791004@git.wordpress.org>
@github-actions github-actions bot mentioned this issue Mar 22, 2024
Merged
github-actions bot referenced this issue Mar 25, 2024
@torounit @t-hamano
Add support "HTML Element" to Site Tagline (#59654)
82bd9a0 
* add tagName to attributes

* update fixture

* use HeadingLevelDropdown

* update site-tagline

* fix json

* Update packages/block-library/src/site-tagline/index.php

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

---------

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
github-actions bot referenced this issue Mar 26, 2024
@gutenbergplugin
Update Changelog for 18.0.0-rc.2
e23ccad
This was referenced Mar 27, 2024
Merged
Merged
github-actions bot referenced this issue Apr 3, 2024
@oandregal @youknowriad
DataViews: remove onDetailsChange event (#60387)
5406de6 
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@github-actions github-actions bot mentioned this issue Apr 3, 2024
Merged
github-actions bot referenced this issue Apr 8, 2024
@jorgefilipecosta
Fix: Dont show pattern and template actions on the post editor. (#60568)
7c25dc4 
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
This was referenced Apr 8, 2024
Merged
Merged
Closed
github-actions bot referenced this issue Apr 14, 2024
@ellatrix @richtabor
Block editor: remove root appender (#60697)
79afedd 
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
github-actions bot referenced this issue Apr 15, 2024
@flexseth @Mamaduka
Combobox: Add links to related components (#60726)
cca1f55 
Co-authored-by: flexseth <flexseth@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
@github-actions github-actions bot mentioned this issue Apr 15, 2024
Merged
github-actions bot referenced this issue Apr 17, 2024
@fabiankaegy @youknowriad @noisysocks
Enable template preview in post editor for non administrators (#60447)
e44ba47 
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
This was referenced Apr 17, 2024
Merged
Draft
Merged
Merged
Merged
This was referenced Apr 30, 2024
Merged
Merged
This was referenced May 1, 2024
Open
Closed
Merged
Merged
@Mamaduka Mamaduka mentioned this issue May 3, 2024
Merged
@sirreal sirreal mentioned this issue May 3, 2024
Merged
@sirreal
Copy link
Member

sirreal commented May 3, 2024

Proposed fix: #61359

sirreal added a commit that referenced this issue May 3, 2024
@sirreal
Tests: Fix flaky interactivity deferred test (#61359)
dde38de 
Fix flaky test #59899

> Locator: getByTestId('result')
> Expected string: ""
> Received string: "Hello, world!"

The test expects to find some empty HTML initially, then find updated text. The text is updated on a timeout.
I suspect the timeout is too short, causing this the flakiness.

Double the timeout to make the test more reliable.
@github-actions github-actions bot reopened this May 28, 2024
github-actions bot referenced this issue May 28, 2024
@youknowriad @ntsekouras
@Mamaduka @joedolson @huzaifaalmesbah
Post Sticky Toggle: Improve the design (#62012)
486a381 
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
@sirreal
Copy link
Member

sirreal commented May 28, 2024

We could increase the timeout further but let's close this again and see if it continues to have flakiness. It's happened once in a month.

@sirreal sirreal closed this as completed May 28, 2024
@github-actions github-actions bot reopened this Jun 14, 2024
@github-actions github-actions bot mentioned this issue Jun 14, 2024
Merged
@sirreal sirreal mentioned this issue Jun 14, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 14, 2024
@sirreal
Copy link
Member

sirreal commented Jun 14, 2024

I've prepared a fix that should be more robust in #62571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirreal sirreal

Labels
[Status] In Progress Tracking issues with work in progress [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
No milestone
1 participant
@sirreal