Try "Add Pattern" UI for zoom out quick inserter #61316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +345 B (+0.02%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3bc5446. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8922247878
|
This reverts commit 3bc5446.
|
I tested this and it's great 👏🏻 - but I don't get the flow of when do these inserters show? |
Looks like they show as they are visible on the viewport, but it make more sense for them to appear on hover? I don't like that they toggle you out of zoom out mode. But if we change that, would it make sense to keep the sidebar open too? Is that an a11y issue? |
|
Closing in favor of #61434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WIP
Closes #59739
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast