Screen takeover using react-modal #6241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/WordPress/gutenberg into add/slot-fill-screen-takeover-api
…the functionality to the render function
4 tasks
boblinthorst
force-pushed
the
try/react-modal-screen-takeover
branch
from
89b0177
to
82b5cc5
Compare
|
Superseded by #6261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull, I've used react-modal to make a screen takeover. Based on the following mockups:
https://cloudup.com/cRhqngZCduC
How has this been tested?
Unit tests have been written for the actions and reducers. It has also been manually tested by adding a screen takeover from a plugin. And seeing if it works as intended.
Screenshots
Types of changes
Checklist: