Add margin-bottom lint rules for FocalPointPicker, TextareaControl, TreeSelect #63633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Jul 16, 2024
.eslintrc.js
Outdated
| @@ -392,6 +400,7 @@ module.exports = { | |||
| excludedFiles: [ | |||
| 'packages/components/src/utils/colors-values.js', | |||
| 'packages/components/src/theme/**', | |||
| '**/*.@(native|ios|android).js', | |||
There was a problem hiding this comment.
Not excluding these mobile files was an oversight.
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Jul 17, 2024
49 tasks
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…reeSelect (WordPress#63633) * Add margin-bottom lint rules for FocalPointPicker, TextareaControl, TreeSelect * Exclude stories and tests * Fixup * Fixup again Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Adds eslint rules to prevent new instances of the following components to be introduced in the Gutenberg codebase without the
__nextHasNoMarginBottomprop being added:Why?
We basically should've done this when we did the initial migration work for each component — we underestimated the time it would take to complete the entire deprecation process for the
BaseControl-based family of components.The three components being linted here do not have new violations from the time we did the original migrations.
While I work through the list of components again to fix the new violations, these lint rules should prevent new violating usages from being added. Once all that is done, we can start logging an actual deprecation warning.
Testing Instructions
The linter should pass. It should fail if you add a still-violating component like
ComboboxControlto the array.