Add margin-bottom lint rules for SelectControl #64283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't matter because this is wrapped in a ToolsPanelItem, which already does normalization on BaseControl margins.
49 tasks
mirka
commented
Aug 6, 2024
| @@ -44,6 +44,7 @@ export default function ResolutionTool( { | |||
| panelId={ panelId } | |||
| > | |||
| <SelectControl | |||
| __nextHasNoMarginBottom | |||
There was a problem hiding this comment.
Doesn't matter because this is wrapped in a ToolsPanelItem, which already does normalization on BaseControl margins.
| <SelectControl | ||
| label={ labelComponent } | ||
| options={ sizeOptions } | ||
| __nextHasNoMarginBottom |
There was a problem hiding this comment.
Doesn't matter because this is a test.
Comment on lines
+80
to
+81
| __nextHasNoMarginBottom | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
Testing instructions
Enable the "Form and input blocks" experiment at wp-admin/admin.php?page=gutenberg-experiments. In the editor, add a Form block and see the block inspector.
Comment on lines
+160
to
+161
| __next40pxDefaultSize | ||
| __nextHasNoMarginBottom |
There was a problem hiding this comment.
Testing instructions
In the editor, add a Post Navigation block and see the Advanced section in the block inspector.
| Before | After |
|---|---|
 |
 |
Comment on lines
+318
to
+319
| __nextHasNoMarginBottom | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
Testing instructions
In Global Styles, go to Typography ▸ Manage Fonts ▸ Install Fonts.
| Before | After |
|---|---|
 |
 |
|
Size Change: +1.75 kB (+0.1%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Aug 6, 2024
| @@ -27,6 +27,7 @@ const orderOptions = [ | |||
| function OrderControl( { order, orderBy, onChange } ) { | |||
| return ( | |||
| <SelectControl | |||
| __nextHasNoMarginBottom | |||
There was a problem hiding this comment.
Testing instructions
In the editor, add a Query Loop block and see the block inspector. Toggle the "Query type" to "Custom".
tyxla
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Looks good, thanks @mirka 👍 Very useful testing instructions as always 🚀
A few potential areas we might have missed to update - please check them before merging:
- https://github.com/WordPress/gutenberg/blob/margin-lint-7/packages/block-editor/src/components/inspector-controls/README.md#L129-L138
- https://github.com/WordPress/gutenberg/blob/margin-lint-7/packages/components/src/dimension-control/index.tsx#L88-L96
- https://github.com/WordPress/gutenberg/blob/margin-lint-7/packages/components/src/select-control/stories/index.story.tsx#L37-L61
- https://github.com/WordPress/gutenberg/blob/margin-lint-7/packages/components/src/select-control/test/select-control.tsx
- https://github.com/WordPress/gutenberg/blob/margin-lint-7/packages/components/src/tree-select/index.tsx#L95-L99
- A formatting issue in https://github.com/WordPress/gutenberg/blob/margin-lint-7/packages/components/src/tree-select/index.tsx#L40 which I discovered by accident and we seem to have introduced in Add margin-bottom lint rules for FocalPointPicker, TextareaControl, TreeSelect #63633
| @@ -69,6 +69,7 @@ $footer-height: 70px; | |||
| color: $gray-900; | |||
| } | |||
|
|
|||
| // TODO: See if this can be removed after https://github.com/WordPress/gutenberg/issues/38730 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Adds eslint rules to prevent new instances of
SelectControlto be introduced in the Gutenberg codebase without the__nextHasNoMarginBottomprop being added.Why?
These lint rules should prevent new violating usages from being added, until we are ready to officially deprecate the margins on the BaseControl-based components all at once.
Testing Instructions
See code comments.