Core Data: Remove leftover 'todo' comment #63842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
westonruter
added a commit
that referenced
this pull request
Jul 23, 2024
* trunk: (2604 commits) Update "Versions in WordPress" page (#63869) SelectControl: Fix hover/focus color in wp-admin (#63855) Add margin-bottom lint rules for RangeControl (#63821) JSON Schema Docgen Rework (#63868) JSON Schema Reorganization and Fixes (#63591) DataForm: Add a simple story for the DataForm component (#63840) Quick Edit: Support bulk selection (#63841) Update dataviews docs (#63860) Bump the github-actions group across 1 directory with 4 updates (#63808) Add unit tests for the gutenberg_render_block_core_post_title() function. Make hover block outlines not present in Distraction Free (#63819) DataViews: Rename the header property of fields to label (#63843) Fix: Error while Calling edit-site getCurrentTemplateTemplateParts selector (#63818) Revert "Update HeightControl component to label inputs" (#63839) Zoom out: hide vertical toolbar when block is not full width (#63650) Latest comments: Add color block support (#63419) Core Data: Remove leftover 'todo' comment (#63842) Tabs: keep full opacity of focus ring on disabled tabs (#63754) Fix selected row styles in table layout (#63811) Align checkbox, radio, and toggle input design (#63490) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a minor follow-up to #63322.
PR removes a
@todocomment to mark string-based resources as deprecated/legacy in the future.Why?
Using string REST API resource is still valid for some packages like
block-directoryor when exposing a resource as an entity doesn't make sense.gutenberg/packages/block-directory/src/components/downloadable-blocks-panel/index.js
Lines 29 to 32 in fb1f9a9
Testing Instructions
None - I just deleted an inline comment.