Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectControl: Fix hover/focus color in wp-admin #63855

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented Jul 23, 2024

Reported in #63815 (comment)

What?

Ensures that the focus/hover color styles in the forms.css (loaded globally in wp-admin) do not override the intended styles for SelectControl.

Testing Instructions

In Storybook, use the global CSS injector tool in the toolbar to load the wp-admin styles. For both SelectControl variants (default and minimal), check that the hover/focus styles are as intended.

CSS injector tool

Screenshots or screencast

Before

Fixed hover styles in SelectControl

@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jul 23, 2024
@mirka mirka self-assigned this Jul 23, 2024
@mirka mirka requested a review from ajitbohra as a code owner July 23, 2024 12:48
Copy link

github-actions bot commented Jul 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Before After
Screenshot 2024-07-23 at 16 48 22 Screenshot 2024-07-23 at 16 48 52

@tyxla
Copy link
Member

tyxla commented Jul 23, 2024

✅ Confirming minimal too:

Before After
Screenshot 2024-07-23 at 16 51 12 Screenshot 2024-07-23 at 16 51 01

Copy link
Contributor

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@mirka mirka enabled auto-merge (squash) July 23, 2024 17:48
@mirka mirka merged commit 40140e4 into trunk Jul 23, 2024
61 checks passed
@mirka mirka deleted the fix/select-control-forms branch July 23, 2024 18:24
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 23, 2024
westonruter added a commit that referenced this pull request Jul 23, 2024
* trunk: (2604 commits)
  Update "Versions in WordPress" page (#63869)
  SelectControl: Fix hover/focus color in wp-admin (#63855)
  Add margin-bottom lint rules for RangeControl (#63821)
  JSON Schema Docgen Rework (#63868)
  JSON Schema Reorganization and Fixes (#63591)
  DataForm: Add a simple story for the DataForm component (#63840)
  Quick Edit: Support bulk selection (#63841)
  Update dataviews docs (#63860)
  Bump the github-actions group across 1 directory with 4 updates (#63808)
  Add unit tests for the gutenberg_render_block_core_post_title() function.
  Make hover block outlines not present in Distraction Free (#63819)
  DataViews: Rename the header property of fields to label (#63843)
  Fix: Error while Calling edit-site getCurrentTemplateTemplateParts selector (#63818)
  Revert "Update HeightControl component to label inputs" (#63839)
  Zoom out: hide vertical toolbar when block is not full width (#63650)
  Latest comments: Add color block support (#63419)
  Core Data: Remove leftover 'todo' comment (#63842)
  Tabs: keep full opacity of focus ring on disabled tabs (#63754)
  Fix selected row styles in table layout (#63811)
  Align checkbox, radio, and toggle input design (#63490)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants