-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Excerpt: Add border block support #64022
Conversation
Flaky tests detected in 5aee5a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10125060867
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍
This tests pretty well for me. It just needs a default box-sizing: border-box
style added as noted on a couple of your other block support PRs.
✅ Global styles display correctly
✅ Block instance styles override global styles
✅ Styling is consistent between editor and frontend
❌ Missing box-sizing style
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +392 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working as advertised, nice job! 👍
✅ Global border styles apply correctly
✅ Block instance styles override global styles
✅ Styles are applied consistently between editor and frontend
✅ Box sizing takes into account border when parent enforces width
What?
Add border block support to the
Post Excerpt
block.Part of #43247
Why?
Post Excerpt
block is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Post Excerpt
block's border is configurable via Global StylesPost Excerpt
block and Apply the border stylesPlease refer to the attached video for more information.
Screenshots or screencast
Blog-Home-.-Template-.-gutenberg-.-Editor-.-WordPress.11.webm