Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Border Design Tools Consistency #43247

Open
aaronrobertshaw opened this issue Aug 16, 2022 · 8 comments
Open

Tracking: Border Design Tools Consistency #43247

aaronrobertshaw opened this issue Aug 16, 2022 · 8 comments
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@aaronrobertshaw
Copy link
Contributor

aaronrobertshaw commented Aug 16, 2022

Overview

This issue details the current state of border block support or design tool adoption across all blocks and tasks required to fill any gaps. Overall design tool consistency efforts are being tracked via the parent issue: #43241.

Legend

Value Description
Feature has been adopted and is displayed as a default control
✅ (Optional) Feature has been adopted but is an optional control
There is a bug or issue with this block support feature's adoption
Feature has been explicitly opted out of
<PR#> Links to PR adopting the feature for this block
- Feature has not explicitly been adopted/omitted
🛠 Implemented via an ad hoc / bespoke control
🚧 Work is in progress towards adopting this feature (no PR yet)

Block Support Adoption

Note: Deprecated blocks have been omitted from this table. e.g. Comment Author Avatar, Post Comment & Text Columns.

Block Color Radius Style Width
Archives #63400 #63400 #63400 #63400
Audio - - - -
Avatar ✅ (Optional) ✅ (Optional) ✅ (Optional)
Button
Buttons
Calendar #64345 #64345 #64345 #64345
Categories
Code ✅ (Optional) ✅ (Optional)
Column
Columns
Comment Author Avatar ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Comment Author Name
Comment Content
Comment Date
Comment Edit Link ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Comment Reply Link ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Comment Template
Comments - - - -
Comments Pagination - - - -
Comments Pagination Next #64310 #64310 #64310 #64310
Comments Pagination Numbers - - - -
Comments Pagination Previous #64308 #64308 #64308 #64308
Comments Title ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Cover
Details
Embed - - - -
File
Footnotes ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Gallery
Group
Heading
Home Link - Navigation - - - -
HTML - - - -
Image
Latest Comments - - - -
Latest Posts - - - -
List ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
List Item ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Login/logout ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Media & Text
More (Read More) - - - -
Navigation - - - -
Navigation Link - - - -
Navigation Submenu - - - -
Next Page (Page Break) - - - -
Page List - - - -
Paragraph ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Post Author
Post Author Biography
Post Author Name
Post Comment - - - -
Post Comments Count - - - -
Post Comments Form
Post Comments Link - - - -
Post Content - - - -
Post Date
Post Excerpt
Post Featured Image
Post Navigation Link #64258 #64258 #64258 #64258
Post Template - - - -
Post Terms
Post Title
Preformatted
Pullquote
Query 🚫 🚫 🚫 🚫
Query No Results - - - -
Query Pagination - - - -
Query Pagination Next - - - -
Query Pagination Numbers - - - -
Query Pagination Previous - - - -
Query Title
Quote
Read More ✅ (Optional) ✅ (Optional) -
RSS - - - -
Search ⚠ ✅ ⚠ ✅ - ⚠ ✅
Separator - - - -
Site Logo #48354 #48354 #48354 #48354
Site Tagline ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Site Title ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Social Link #63782 #63782 #63782 #63782
Social Links
Spacer - - - -
Table 🚫
Table of Contents
Tag Cloud
Term Description
Time To Read ✅ (Optional) ✅ (Optional) ✅ (Optional) ✅ (Optional)
Verse
Video #63777 #63777 #63777 #63777

Merged PRs

@aaronrobertshaw aaronrobertshaw added [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 16, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 16, 2022
@aaronrobertshaw
Copy link
Contributor Author

An overall update on progress towards design tools consistency has been added to the primary tracking issue, including our goals for WordPress 6.1.

@t-hamano
Copy link
Contributor

Update: I have added the Footnotes and Details blocks to the list.

@markhowellsmead
Copy link

Why have border radius on the details block and border style on images specifically been excluded? These make sense.

@aaronrobertshaw
Copy link
Contributor Author

There's a fairly lengthy history regarding the details block and adopting border-radius on the original PR that implemented the block (#49808).

The TL;DR from memory is that adopting border-radius on some blocks can lead to a UX issue where the inline block inserter gets clipped and end users can no longer easily add blocks. The Column block is another example of this. I believe border radius was being only sparingly adopted until an overall solution can be found.

Regarding border-style on images, it was decided to be removed here. As we have recently had the merged global styles data added to the block editor, I think a lot of the poor experience around default border-style behaviour can now be avoided and this decision is worth revisiting.

@markhowellsmead
Copy link

Regarding border-style on images, it was decided to be removed here

Perhaps @mtias can suggest whether it's appropriate to revise this: the linked comment is getting on for three years old, and there have been so many editor improvements in the mean time.

@t-hamano
Copy link
Contributor

Update: I have updated the table with the latest specs.

@aaronrobertshaw
Copy link
Contributor Author

I've updated the merged PRs list so people following along can see what's landed easier.

The revisions for the issue description aren't the easiest to grok, so if you get the chance to make sure I linked the correct PRs @t-hamano, that would be appreciated 🙏

@t-hamano
Copy link
Contributor

t-hamano commented Jul 29, 2024

I've rechecked all the core blocks and added all the PRs that added border support to the merged PRs list 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

3 participants