Comment Content: Add Border Support #64230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +99 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 097e709. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10355560822
|
shail-mehta
added
the
[Feature] Design Tools
shail-mehta
requested review from
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
t-hamano
reviewed
Aug 4, 2024
talldan
changed the title
There was a problem hiding this comment.
Thanks for this one @shail-mehta 👍
It is testing pretty well although I did encounter an issue with box-sizing not being applied in the editor.
✅ Global Styles applies borders correctly to block
✅ Block instance styles override Global Styles borders
✅ Borders display correctly in both the editor and frontend
❓ Box sizing in editor doesn't appear to be set to border-box
✅ Box sizing on the frontend is border-box allowing parent Group block to enforce a width
This is what I see in either editor. Note the selected Group block has a content width of 300px set and the highlighted DOM element for Comment Content block being a greater width than 300px.
|
@aaronrobertshaw Thank you for the Feedback. I will check border-box issue in editor side. |
|
@aaronrobertshaw I have Fixed Border Box Issue in Editor Side in Latest Commit. |
shail-mehta
force-pushed
the
add/comment-content-border-support
branch
from
c1d3f64
to
097e709
Compare
shail-mehta
force-pushed
the
add/comment-content-border-support
branch
from
e6719fd
to
57237e1
Compare
aaronrobertshaw
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Nice work @shail-mehta ✨
This works well for me. I think it is time to merge.
✅ Global styles apply correctly
✅ Block instance styles override global styles
✅ Styles are applied correctly in both editors and frontend
✅ Box sizing allows parent to enforce width
✅ As padding control is displayed by default, border controls also make sense
Screen.Recording.2024-08-15.at.11.37.21.AM.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Comment Contentblock.Part of #43247
Why?
Comment Contentblock is missing border support.How?
Adds the border block support in block.json.
Testing Instructions
Comment Contentblock's border is Configurable via Global Styles.Comment Contentblock and Apply the border Styles.Comment Contentblock styles take precedence over global Styles.Comment Contentblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-comment-content-block.mp4