Apply Global Border-Box Sizing to all blocks that have a border style #64788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
shail-mehta
requested review from
ZebulanStanphill,
michalczaplinski and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
shail-mehta
changed the title
shail-mehta
changed the title
|
Size Change: -2.67 kB (-0.15%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
shail-mehta
force-pushed
the
add/box-sizing-borderbox-globally-in-all-blocks
branch
from
0892489
to
3b609a4
Compare
| * and a style attribute containing 'border'. | ||
| * This ensures consistent box-sizing behavior and makes layout calculations more predictable. | ||
| */ | ||
| [class*="wp-block-"][style*="border"] { |
There was a problem hiding this comment.
One catch with this selector is that it would only apply to blocks with border styles applied on the block instance. If a border was applied to a block type via global styles it wouldn't have the correct box-sizing.
This also only covers the application of borders where box-sizing has historically been set for blocks that adopt padding support as well.
There was a problem hiding this comment.
Thank you for your valuable feedback. I will work on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a global rule to apply box-sizing: border-box to all blocks that have a border style.
Follow Up of #43247 (Discussion #64615 (comment))
Used Global CSS Instead of box-sizing: border-box separately in all blocks.