Connected blocks, add backdrop-color. #65233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +459 B (+0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
CC: @WordPress/gutenberg-design, this is not a huge change, it's just a tweak to the existing purple connection color for bound blocks. |
|
I don't have a strong opinion about the purple background color, but I think this style should only be applied to the Template Part:
Synced Pattern:
|
|
Excellent point. Agreed, and done. |
|
I'd be curious to try this—the slightly stronger signal makes it more clear at a glance that the block is in a special state. |
|
There seems to be a scale animation ( Looks good otherwise. |
|
I agree this looks like an improvement to the current UX. In my tests, it seems the pattern overrides icon doesn't change. Should these styles be applied there? Connected to custom fields In pattern overrides EDIT: If wanted, this could potentially be solved using something like this I believe: .components-button:has( .block-editor-block-icon )::beforeAdditionally, I am not sure if it is on purpose, but I agree the animation feels a bit weird. |
64 tasks
|
This is what I see: 
It looks slightly different for Pattern Overrides: 
Would it make sense to unify everything, including the backdrop color for the icon in the block details? The icon for Pattern Overrides already has the color applied, so that should follow with other cases. |
|
Thanks for all the feedback. I'm back from a bit of AFK and catching up.
Wouldn't that conflict with Aki's feedback, which I agreed with, here? |
I'm not sure I follow that feedback. What I was trying to see is as follows:
|
|
I think the purple color will be displayed in one of the following situations:
Isn't the purpose of this PR to visually distinguish only connected blocks? Also, I remember that connected blocks used to have a special icon on their toolbar. I don't know why this icon was removed, but instead of adding a background color, would bringing this icon back be another approach? |
Ah, my apologies, I did miss nuance. I don't know that I necessarily agree, though I also don't disagree. Is it a blocker for this PR, though, given the inspector does not use the purple color at all, at the moment?
I think of these as different.
Exactly, this is a slight differentiation. Note, this is a small PR, easy to tune/tweak. Let me know if I'm missing a beat! |
gziolo
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
We can iterate. I'm happy with the enhancement for the toolbar 😄
@jasmussen, happy to include in WP 6.7?
Would love it, yes. Thank you. |
gziolo
added
the
Backport to WP 6.7 Beta/RC
|
@noisysocks and @kevin940726, not sure if it auto-syncs to |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 24, 2024
Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 33b287a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #65199. Adds a purple backdrop to the icon itself, so it's easier to tell at a glance.
Before:
After: