Connected/synced blocks: show backdrop across all #65911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you for adding this Joen. This will be helpful. |
|
Size Change: +50 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Isn't there a subtle distinction here? In Trunk, the backdrop is applied to blocks that reference data sources, which function somewhat like partially synced patterns. On the other hand, fully synced blocks like template parts may not reference data sources at all. So, applying the same visual treatment to both cases might convey different meanings. It seems like the accent might be more fitting if applied to the entire toolbar (in some way) for fully synced blocks. However, I wonder if this level of detail might be too granular to represent clearly, in which case please ignore me :) I noticed the backdrop is not applied to template parts when editing posts/pages with the template visible: 
|
To be clear, the motivation here is to apply identical treatment to any block that is "connected" in any capacity whatsoever. To that end, it would be both synced patterns, blocks with bindings, and sure, even template parts. How would you feel about this treatment being applied to that as well? (Good catch.) |
|
Down the road I reckon it might be worth exploring an iteration that distinguishes between partially synced/connected and fully-synced. But that doesn't need to hold this up :) |
|
Is it worth landing this one, then? Not with urgency, it's not going to be a 6.7 thing, just wondering. |
t-hamano
approved these changes
Oct 8, 2024
|
We should probably include template parts in the post editor before merging, no? |
|
Oh yes, good catch, I'll do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #65233. Show the connected block "backdrop" across synced blocks as well. Before:
After:
Why?
The main purpose of the backdrop is to provide further differentiation between standard blocks and special blocks. Whether synced or connected to data sources, both types are "special", and differentiating further between the two may not be worth it.
Testing Instructions
Test connected, default, and synced blocks, be sure to test the focus style which should be unchanged. An easy way to test a connected block is to drop this in your functions.php:
Then go add the random_image source to your Image block.