Resizable Editor: Make the editor resizable with arrow keys #65546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I tested in trunk and the arrow keys are still working correctly 🤔. I must be missing something. Could you share your environment, e.g. the browsers or the setup?
Either way, I think this is still a good improvement! |
|
Thanks for the review!
After further investigation, it appears that, as mentioned in this comment, this is due to the text cursor mode in the Chrome browser and Windows OS. When this mode is enabled, it seems that the focus may move unintentionally using the arrow keys. This mode can be disabled with the The video below is a test on trunk; in the first half, the text cursor mode is enabled, and in the second half, it is disabled: 6d472ffe5445f97e48cb9edc03f7aec4.mp4In any case, it seems that |
t-hamano
added
the
OS Issues
kevin940726
approved these changes
Sep 24, 2024
| if ( keyCode !== LEFT && keyCode !== RIGHT ) { | ||
| return; | ||
| } | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Should we add a comment referencing this issue, or do you think it's a common practice? I think maybe it's fine to leave it to git blaming to do its work 😅.
There was a problem hiding this comment.
I think if we want to add our own event to an event, it is common to add event.preventDefault(), and there are a lot of uncommented event.preventDefault() in Gutenberg 😅 Therefore, I personally think that a comment is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I found that although the resize handles of the resizable editor are keyboard focusable, pressing the left or right key takes the focus away, making it impossible to resize the editor.
Why?
This is probably due to the influence of other event handlers.
How?
As with here, check the key and add
event.preventDefault().Testing Instructions
Screenshots or screencast
2bebcb09b62e66f225248addc186203e.mp4