Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable Editor: Make the editor resizable with arrow keys #65546

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Resizable Editor: Make the editor resizable with arrow keys #65546

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20ec084
Resizable Editor: Make the editor resizable with arrow keys
t-hamano Sep 22, 2024
1563c2d
Merge branch 'trunk' into resizable-editor-keyboard-navigation
t-hamano Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/editor/src/components/resizable-editor/resize-handle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ export default function ResizeHandle( { direction, resizeWidthBy } ) {
function handleKeyDown( event ) {
const { keyCode } = event;

if ( keyCode !== LEFT && keyCode !== RIGHT ) {
return;
}
event.preventDefault();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment referencing this issue, or do you think it's a common practice? I think maybe it's fine to leave it to git blaming to do its work 😅.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we want to add our own event to an event, it is common to add event.preventDefault(), and there are a lot of uncommented event.preventDefault() in Gutenberg 😅 Therefore, I personally think that a comment is unnecessary.


if (
( direction === 'left' && keyCode === LEFT ) ||
( direction === 'right' && keyCode === RIGHT )
Expand Down
Loading