Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Drop deprecations slated for 2.8 removal #6559

Merged
merged 1 commit into from
May 3, 2018
Merged

Framework: Drop deprecations slated for 2.8 removal #6559

merged 1 commit into from
May 3, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented May 3, 2018 •
edited
Loading

This pull request seeks to remove deprecations slated for removal in the upcoming 2.8.0 release.

Specifically, this includes:

  • Original autocompleter interface in wp.components.Autocomplete
  • getInserterItems: the allowedBlockTypes argument is now mandatory
  • getFrecentInserterItems: the allowedBlockTypes argument is now mandatory

See: https://wordpress.org/gutenberg/handbook/reference/deprecated/#2-8-0

Testing instructions:

Verify that there are no regressions in impacted behavior, and importantly that no references to deprecated behaviors exist in core code.

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label May 3, 2018
@aduth aduth added this to the 2.8 milestone May 3, 2018
@aduth aduth requested review from brandonpayton and noisysocks May 3, 2018 12:50
@aduth aduth mentioned this pull request May 3, 2018
Merged
youknowriad
youknowriad approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aduth aduth merged commit 98859d5 into master May 3, 2018
@aduth aduth deleted the remove/2-8-deprecations branch May 3, 2018 16:23
@brandonpayton brandonpayton mentioned this pull request Jul 19, 2018
Merged
4 tasks
@ramonjd ramonjd mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@brandonpayton brandonpayton Awaiting requested review from brandonpayton

@noisysocks noisysocks Awaiting requested review from noisysocks

Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @youknowriad