Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused autocompleter backcompat case #8058

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Remove unused autocompleter backcompat case #8058

merged 1 commit into from
Jul 19, 2018

Conversation

brandonpayton
Copy link
Member

Description

This PR removes a backcompat case that has been unused since we merged #6559.

How has this been tested?

  • Ran unit and e2e tests.
  • Manually tested block and user completers which exercise both supported completion actions insert-at-caret and replace.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@brandonpayton brandonpayton added [Feature] Extensibility The ability to extend blocks or the editing experience [Type] Code Quality Issues or PRs that relate to code quality labels Jul 19, 2018
@brandonpayton brandonpayton requested a review from gziolo July 19, 2018 19:38
gziolo
gziolo approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚢

gziolo
gziolo reviewed Jul 19, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missed it 😃

@brandonpayton brandonpayton merged commit 99737c3 into master Jul 19, 2018
@brandonpayton
Copy link
Member Author

Thanks, @gziolo!

@brandonpayton brandonpayton deleted the remove/unused-autocompleter-backcompat branch July 19, 2018 21:33
@mtias mtias added this to the 3.3 milestone Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonpayton @gziolo @mtias