Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change keyboard shortcut for remove block to Cmd+Shift+X / Ctrl+Shift+X #9190

Merged
merged 5 commits into from
Aug 28, 2018
Merged

Change keyboard shortcut for remove block to Cmd+Shift+X / Ctrl+Shift+X #9190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99b9f05
Change keyboard shortcut for remove block to crl+shift+-
talldan Aug 21, 2018
b469cda
Handle Firefox variance of the minus keycode
talldan Aug 21, 2018
d1487a0
Update test snapshot
talldan Aug 21, 2018
75825ac
Change shortcut for remove block to primary shift x
talldan Aug 27, 2018
486ac46
Update keyboard shortcuts in faq docs
talldan Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference/faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ This is the canonical list of keyboard shortcuts:
### Block shortcuts

* <kbd>Shift</kbd>+<kbd>⌘D</kbd> Duplicate the selected block(s).
* <kbd>Option</kbd>+<kbd>⌘Backspace</kbd> Remove the selected block(s).
* <kbd>Shift</kbd>+<kbd>⌘X</kbd> Remove the selected block(s).
* <kbd>Option</kbd>+<kbd>⌘T</kbd> Insert a new block before the selected block(s).
* <kbd>Option</kbd>+<kbd>⌘Y</kbd> Insert a new block after the selected block(s).
* <kbd>/</kbd> Change the block type after adding a new paragraph.
Expand Down
2 changes: 1 addition & 1 deletion edit-post/components/keyboard-shortcut-help-modal/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const blockShortcuts = {
description: __( 'Duplicate the selected block(s).' ),
},
{
keyCombination: primaryAlt( 'backspace' ),
keyCombination: primaryShift( 'x' ),
description: __( 'Remove the selected block(s).' ),
},
{
Expand Down
4 changes: 2 additions & 2 deletions edit-post/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ exports[`KeyboardShortcutHelpModal should match snapshot when the modal is activ
"keyCombination": Array [
"Ctrl",
"+",
"Alt",
"Shift",
"+",
"Backspace",
"X",
],
},
Object {
Expand Down
4 changes: 2 additions & 2 deletions packages/editor/src/components/block-settings-menu/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ const shortcuts = {
display: displayShortcut.primaryShift( 'd' ),
},
removeBlock: {
raw: rawShortcut.primaryAlt( 'backspace' ),
display: displayShortcut.primaryAlt( 'bksp' ),
raw: rawShortcut.primaryShift( 'x' ),
display: displayShortcut.primaryShift( 'x' ),
},
insertBefore: {
raw: rawShortcut.primaryAlt( 't' ),
Expand Down