Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove snafu #60

Merged
merged 2 commits into from
Mar 19, 2024
Merged

remove snafu #60

merged 2 commits into from
Mar 19, 2024

Conversation

burrbull
Copy link
Contributor

No description provided.

@XAMPPRocky XAMPPRocky merged commit ce3c428 into XAMPPRocky:master Mar 19, 2024
8 checks passed
@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@github-actions github-actions bot mentioned this pull request Mar 19, 2024
@torokati44
Copy link
Contributor

BTW This PR bumped the flume dependency to 0.11.0 in the main crate, but not in macros, thereby causing a version duplication of it:
https://github.com/ruffle-rs/ruffle/actions/runs/8701668584/job/23864127408#step:5:589

You could consider setting up the common dependencies as workspace level ones, a la: ruffle-rs/ruffle#15868

@XAMPPRocky
Copy link
Owner

Yes we should, PR doing so are welcome this crate was made before that feature existed.

@torokati44
Copy link
Contributor

There you go: #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants