Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of cut classes: LowEnergyBackground #95

Closed
tunnell opened this issue Nov 10, 2017 · 1 comment
Closed

Naming of cut classes: LowEnergyBackground #95

tunnell opened this issue Nov 10, 2017 · 1 comment

Comments

@tunnell
Copy link
Member

tunnell commented Nov 10, 2017

In #86 various things were removed and I think that created some confusions.

First, there is LowEnergyBackground and LowEnergyRn220, so what do people use? LowEnergyBackground contains a junk cut that we don't want on AmBe or DD, right?

Nevertheless, it should always be clear to the analyst which to use so maybe for now rename LowEnergyBackground to LowEnergy?

Also, the fiducial volume cut can be simplified so it's not redefined. Move source position to the class. Then in SR1 do:

FiducialVolume = sr0.FiducialVolume FiducialVolume.position = blah

@pdeperio
Copy link
Contributor

Should be fixed in last two PRs above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants