Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Calibration Source Classes #86

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Conversation

sreichard
Copy link
Contributor

I removed the 'LowEnergyAmBe' and 'LowEnergyNG' classes but left the original definitions of the FV's designed for the calibration sources, in case someone wants to use them in the future. I also moved S2Tails from 'AllEnergy' to 'LowEnergyBackground', where it belongs.

Copy link
Contributor

@pdeperio pdeperio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @skazama's study here. But did something change in AmBe data from SR0 to SR1 such that we don't need this cut anymore (if not, then we should remove from SR0 too)? Is this consistent with @ErikHogenbirk's study, which first proposed this cut?

@sreichard, you may wish to create a separate PR for S2Tails, so it can be more easily reviewed and merged.

@pdeperio pdeperio requested a review from jpienaar13 October 24, 2017 20:22
@pdeperio pdeperio added this to the v1.1.0 milestone Oct 24, 2017
@ErikHogenbirk
Copy link

As written in Shingo's study, the ER rate has gone down quite a bit. This was one of the reasons to introduce this cut. The other reason was to remove the events that bleed below the band. From Fig. 1.3 in Shingo's note, it indeed seems that this is not necessary (although it's quite hard to estimate point density -- especially as there are many more purple points). It'd be nicer to see the number of leakage events as a function of distance to source.

So... the FV cuts are still in here? The reason I ask is that we don't necessarily want the same FV for a DM run as for calibration. For calibration, you want to be sure of complete charge collection, a proper functioning posrec, etc. For DM, you want all that AND you want minimal background. This will pose a tighter constraint than you need for calibration, so you may end up throwing out lots of your calibration data (since most events are near the edge) for no reason.

@sreichard
Copy link
Contributor Author

@ErikHogenbirk Yes, the FV definitions for AmBe and NG still exist in lax. Analysts can access them with the updated version and change them as needed.

@skazama
Copy link
Contributor

skazama commented Oct 25, 2017

@ErikHogenbirk Concerning FV size, we are currently investigating if we can enlarge FV size for dark matter data, and I'm using 1.3 ton FV also for NR calibration datasets. Its radius is 42.6 cm which is similar size as for SR0 FV cut, so we are not losing statistics. One thing I think we should be careful is that our electric field is not completely uniform, so if we use different FV definitions between dark matter data and calibration data, there could be some differences in the detector responses, so I think it's better to use consistent FV size (although NR has less dependency on field from NEST model).

Put S2Tails back in the 'AllEnergy' class so it can be reviewed in a separate PR.
@andrewgrahambrown andrewgrahambrown merged commit 4caa874 into master Oct 27, 2017
@sreichard sreichard deleted the remove_source_FV branch October 30, 2017 12:44
@pdeperio
Copy link
Contributor

@tunnell mentions that would be nice to keep the LowEnergyAmBe and LowEnergyNG class definitions for backward compatibility, and just not apply them to data. (Also, they're still defined in sciencerun0.py, which should have also been removed for consistency.)

Also, it's not clear now what to apply to AmBe/NG, since we still explicitly have LowEnergyBackground and LowEnergyRn220.

@tunnell
Copy link
Member

tunnell commented Nov 10, 2017

See #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants